Skip to content

test(react-start): new profiling scenario for search/loader/redirect#6511

Merged
Sheraff merged 1 commit intomainfrom
test-react-start-perf-profiling-new-scenario
Jan 25, 2026
Merged

test(react-start): new profiling scenario for search/loader/redirect#6511
Sheraff merged 1 commit intomainfrom
test-react-start-perf-profiling-new-scenario

Conversation

@Sheraff
Copy link
Contributor

@Sheraff Sheraff commented Jan 25, 2026

Summary by CodeRabbit

  • New Features
    • Added a new search page enabling users to search for items with support for filters including query, game, set, rarity, sorting, and price range parameters.
    • Integrated pagination and customizable result limits for improved browsing experience.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 25, 2026

📝 Walkthrough

Walkthrough

A new /search route is added to the React Router application. The changes include creating a new Search route component with search parameter validation and loader setup, registering it in the generated route tree with proper type augmentations, and updating benchmark tests to use the new search endpoint instead of nested paths.

Changes

Cohort / File(s) Change Summary
Route Tree Registration
e2e/react-start/flamegraph-bench/src/routeTree.gen.ts
Adds SearchRoute import and defines new route constant with id /search. Extends FileRoutesByFullPath, FileRoutesByTo, FileRoutesById type mappings to include /search. Adds SearchRoute to RootRouteChildren and augments @tanstack/react-router module declaration with /search path metadata and parent linkage.
Search Route Implementation
e2e/react-start/flamegraph-bench/src/routes/search.tsx
Creates new file-route component with validation schema that coerces and defaults search parameters (q, page, game, set, rarity, limit, sort, order, minPrice, maxPrice). Implements loader that returns search dependencies and SearchPage component that reads query params via useSearch.
Benchmark Test Configuration
e2e/react-start/flamegraph-bench/tests/bench.js
Replaces nested path generation logic with random search query generation. Active requests now target /search?q=... endpoint instead of shuffled alphabet nested routes.

Sequence Diagram(s)

sequenceDiagram
    participant Client as Client/Browser
    participant Router as React Router
    participant Validator as Search Validator
    participant Loader as Search Loader
    participant Component as SearchPage Component

    Client->>Router: Request /search?q=test&page=1
    activate Router
    Router->>Validator: Validate search params
    activate Validator
    Validator->>Validator: Coerce and default params
    Validator-->>Router: Validated search object
    deactivate Validator
    Router->>Loader: Execute loader with search deps
    activate Loader
    Loader-->>Router: Return search params
    deactivate Loader
    Router->>Component: Render with loader data
    activate Component
    Component->>Component: useSearch() to access params
    Component-->>Client: Render SearchPage UI
    deactivate Component
    deactivate Router
Loading

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested Labels

package: react-router

Suggested Reviewers

  • nlynzaad
  • schiller-manuel

Poem

🐰 A search route hops into the tree,
With validation dancing merrily,
Parameters coerced, loaders spun,
The benchmark queries have such fun!
Now /search?q= leads the way,
To findings bright on benchmark day! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a new search route with loader and validation for profiling/benchmarking purposes in the react-start test scenario.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Jan 25, 2026

View your CI Pipeline Execution ↗ for commit 5d14a63

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 1m 11s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-25 17:55:53 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 25, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@6511

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@6511

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@6511

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@6511

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@6511

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@6511

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@6511

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@6511

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@6511

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@6511

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@6511

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@6511

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@6511

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@6511

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@6511

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@6511

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@6511

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@6511

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@6511

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@6511

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@6511

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@6511

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@6511

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@6511

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@6511

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@6511

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-fn-stubs@6511

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@6511

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@6511

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@6511

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@6511

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@6511

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@6511

@tanstack/vue-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router@6511

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-devtools@6511

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-ssr-query@6511

@tanstack/vue-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start@6511

@tanstack/vue-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-client@6511

@tanstack/vue-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-server@6511

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@6511

commit: 5d14a63

@Sheraff Sheraff merged commit 3b61ca2 into main Jan 25, 2026
6 checks passed
@Sheraff Sheraff deleted the test-react-start-perf-profiling-new-scenario branch January 25, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant