Skip to content

ci(nx): update to Nx v22#5982

Merged
lachlancollins merged 1 commit intomainfrom
nx
Nov 27, 2025
Merged

ci(nx): update to Nx v22#5982
lachlancollins merged 1 commit intomainfrom
nx

Conversation

@lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Nov 27, 2025

Summary by CodeRabbit

Chores

  • Upgraded development build tooling to the latest version
  • Updated cloud service integration configuration

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2025

Walkthrough

Configuration key replaced from nxCloudAccessToken to nxCloudId in nx.json. The nx dependency in package.json updated from version 21.3.7 to 22.1.3.

Changes

Cohort / File(s) Summary
Configuration
nx.json
Replaced nxCloudAccessToken with nxCloudId; configuration key and value updated to use a cloud identifier instead of an access token
Dependencies
package.json
Bumped nx in devDependencies from 21.3.7 to 22.1.3

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • nx.json: Straightforward configuration key replacement; verify the new nxCloudId value is correctly formatted and valid for the target Nx Cloud environment
  • package.json: Standard dependency version bump; ensure compatibility with the codebase and check release notes for breaking changes between versions 21.3.7 and 22.1.3

Poem

🐰 The token danced, now replaced with an ID,
And Nx climbed higher—twenty-two's the key,
Config spins smoothly, dependencies align,
A rabbit's workflow: simple, clean, divine! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ci(nx): update to Nx v22' clearly and concisely summarizes the main change: updating Nx to version 22, as confirmed by the package.json version bump from 21.3.7 to 22.1.3.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch nx

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2d74463 and 5e2d7cb.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • nx.json (1 hunks)
  • package.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/package.json

📄 CodeRabbit inference engine (AGENTS.md)

Use workspace protocol for internal dependencies (workspace:*)

Files:

  • package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Test
  • GitHub Check: Preview
🔇 Additional comments (2)
nx.json (1)

4-4: The Nx v22 Cloud configuration migration is correct and complete.

The change from nxCloudAccessToken to nxCloudId follows the official Nx v22 migration path. The workspace ID (6442f7de8226a6291646a813) is properly configured in nx.json, and no access tokens are committed to source control—adhering to security best practices where personal tokens are stored locally and CI tokens use environment variables.

package.json (1)

55-55: Based on my verification of the codebase and the Nx v22 breaking changes, here is the rewritten review comment:


Nx v22 upgrade is compatible with this codebase and does not require additional changes.

The upgrade from Nx 21.3.7 to 22.1.3 should proceed smoothly. This project does not use any of the features with breaking changes in v22:

  • No Nx Release features (no release/version config in nx.json)
  • No custom plugins using createNodes v1 (useInferencePlugins=false)
  • No deprecated environment variables (NX_DISABLE_DB, decorate-cli not used)
  • No legacy-peer-deps configuration in .npmrc
  • All Nx commands in scripts (affected, run-many, watch) are compatible with v22
  • CI workflows use only NX_CLOUD_ACCESS_TOKEN, which remains supported

No code or configuration updates are needed for this upgrade.


Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Nov 27, 2025

View your CI Pipeline Execution ↗ for commit 5e2d7cb

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 10m 13s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 40s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-27 22:24:40 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 27, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5982

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5982

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5982

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5982

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5982

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5982

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5982

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5982

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5982

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5982

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5982

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5982

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5982

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5982

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5982

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5982

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5982

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5982

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5982

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5982

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5982

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5982

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5982

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@5982

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5982

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5982

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5982

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5982

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5982

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5982

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5982

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5982

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5982

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5982

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5982

commit: 5e2d7cb

@lachlancollins lachlancollins merged commit af02265 into main Nov 27, 2025
6 checks passed
@lachlancollins lachlancollins deleted the nx branch November 27, 2025 22:26
naoya7076 pushed a commit to naoya7076/router that referenced this pull request Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant