refactor(router-core): make parsePathnameCache internal#4767
Closed
dsonet wants to merge 2 commits intoTanStack:mainfrom
Closed
refactor(router-core): make parsePathnameCache internal#4767dsonet wants to merge 2 commits intoTanStack:mainfrom
dsonet wants to merge 2 commits intoTanStack:mainfrom
Conversation
dsonet
changed the title
|
View your CI Pipeline Execution ↗ for commit ad42b7b
☁️ Nx Cloud last updated this comment at |
Contributor
|
We intentionally made it a thing that lives on the router, because depending on the setup, some people have several routers. The cache is passed to the appropriate methods internally, and no public APIs were affected. What is your use-case that is impacted by this change? |
Contributor
|
we specifically chose to make the cache router instance specific. all the functions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REF: #4752
It introduced the LRU ache for parsePathname. However, it exposed the internal cache, making it the caller's responsibility to pass the cache. This could defeat the purpose if the parameter is missing.
I'd suggest it's better to keep the cache internal and transparent to the caller. This reduces the burden of passing the cache around and keeps the API cleaner, the bundle size would be smaller as well.