fix(vue): include TPageParam in enabled of InfiniteQueryObserverOptions by aa900031 · Pull Request #9898 · TanStack/query

aa900031 · 2025-11-23T16:39:02Z

🎯 Changes

This PR adds the missing generic type parameters that weren't being passed through properly.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Bug Fixes
- Improved TypeScript type inference for infinite-query options so the enabled configuration now correctly includes the page parameter.
Chores
- Patch changelog entry added documenting the type update and version bump.
Notes
- This is a types-only change; there are no runtime behavior changes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

changeset-bot · 2025-11-23T16:39:06Z

🦋 Changeset detected

Latest commit: 64100b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@tanstack/vue-query	Patch
@tanstack/vue-query-devtools	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-11-23T16:39:13Z

Walkthrough

Adjusted TypeScript types in useInfiniteQuery to propagate the TPageParam generic into the enabled branch of UseInfiniteQueryOptions, changing the InfiniteQueryObserverOptions instantiation to include DeepUnwrapRef<TQueryKey>, TPageParam. No runtime code was modified.

Changes

Cohort / File(s)	Summary
Vue Query type update `packages/vue-query/src/useInfiniteQuery.ts`	Updated the `UseInfiniteQueryOptions` type so the `enabled` branch uses `InfiniteQueryObserverOptions<DeepUnwrapRef<TQueryKey>, TPageParam, ...>` (propagates `TPageParam` and unwraps `TQueryKey`). Type-only change; no runtime behavior changes.
Changeset `.changeset/fancy-eels-see.md`	Added changeset entry documenting the patch bump and noting the inclusion of `TPageParam` in the `enabled` option.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Single-file type signature change plus a changeset entry.
Focus review on generic parameter propagation and any impacts to public type inference.

Files to pay extra attention to:

packages/vue-query/src/useInfiniteQuery.ts — verify generic instantiation and related exported types.
.changeset/fancy-eels-see.md — confirm release notes and version bump text.

Suggested reviewers

DamianOsipiuk

Poem

🐰 A rabbit nudged types with a gentle tap,
TPageParam hopped into the enabled map,
DeepUnwrapRef peeled layers away,
Types aligned, the code can play,
No runtime stir—just a tidy type nap.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding TPageParam to the enabled option of InfiniteQueryObserverOptions in the vue-query package.
Description check	✅ Passed	The PR description follows the required template structure with all sections completed (Changes, Checklist, Release Impact), though the Changes section could be more detailed about the motivation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9f16eaa and 64100b6.

📒 Files selected for processing (1)

.changeset/fancy-eels-see.md (1 hunks)

✅ Files skipped from review due to trivial changes (1)

.changeset/fancy-eels-see.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2025-11-23T16:39:27Z

View your CI Pipeline Execution ↗ for commit 64100b6

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 13s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2s	View ↗

☁️ Nx Cloud last updated this comment at 2025-11-23 16:44:24 UTC

pkg-pr-new · 2025-11-23T16:40:41Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9898

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9898

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9898

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9898

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9898

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9898

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9898

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9898

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9898

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9898

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9898

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9898

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9898

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9898

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9898

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9898

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9898

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9898

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9898

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9898

commit: 64100b6

codecov · 2025-11-23T16:44:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.28%. Comparing base (66a194e) to head (64100b6).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #9898       +/-   ##
===========================================
+ Coverage   45.78%   71.28%   +25.49%     
===========================================
  Files         200       19      -181     
  Lines        8413      484     -7929     
  Branches     1922      140     -1782     
===========================================
- Hits         3852      345     -3507     
+ Misses       4113      109     -4004     
+ Partials      448       30      -418

Components	Coverage Δ
@tanstack/angular-query-experimental	`∅ <ø> (∅)`
@tanstack/eslint-plugin-query	`∅ <ø> (∅)`
@tanstack/query-async-storage-persister	`∅ <ø> (∅)`
@tanstack/query-broadcast-client-experimental	`∅ <ø> (∅)`
@tanstack/query-codemods	`∅ <ø> (∅)`
@tanstack/query-core	`∅ <ø> (∅)`
@tanstack/query-devtools	`∅ <ø> (∅)`
@tanstack/query-persist-client-core	`∅ <ø> (∅)`
@tanstack/query-sync-storage-persister	`∅ <ø> (∅)`
@tanstack/query-test-utils	`∅ <ø> (∅)`
@tanstack/react-query	`∅ <ø> (∅)`
@tanstack/react-query-devtools	`∅ <ø> (∅)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`∅ <ø> (∅)`
@tanstack/solid-query	`∅ <ø> (∅)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`∅ <ø> (∅)`
@tanstack/svelte-query	`∅ <ø> (∅)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`∅ <ø> (∅)`
@tanstack/vue-query	`71.28% <ø> (ø)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

fix(vue): include TPageParam in enabled of InfiniteQueryObserverOptions

9f16eaa

github-actions bot added the package: vue-query label Nov 23, 2025

chore: add changeset

64100b6

DamianOsipiuk merged commit 3ce7910 into TanStack:main Nov 25, 2025
9 checks passed

github-actions bot mentioned this pull request Nov 25, 2025

ci: Version Packages #9909

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(vue): include TPageParam in enabled of InfiniteQueryObserverOptions#9898

fix(vue): include TPageParam in enabled of InfiniteQueryObserverOptions#9898
DamianOsipiuk merged 2 commits intoTanStack:mainfrom
aa900031:fix/vue-query-page-param-not-pass-to-enabled-function

aa900031 commented Nov 23, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Nov 23, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Nov 23, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Nov 23, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Nov 23, 2025 •

edited

Loading

Uh oh!

codecov bot commented Nov 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

aa900031 commented Nov 23, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

nx-cloud bot commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aa900031 commented Nov 23, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Nov 23, 2025 •

edited

Loading

coderabbitai bot commented Nov 23, 2025 •

edited

Loading

nx-cloud bot commented Nov 23, 2025 •

edited

Loading

pkg-pr-new bot commented Nov 23, 2025 •

edited

Loading

codecov bot commented Nov 23, 2025 •

edited

Loading