ci: fix versioning in release workflow#9690
Conversation
|
|
Caution Review failedThe pull request is closed. WalkthroughGuard added to the “Commit version files” step in .github/workflows/release.yml to run git config/add/commit/push only when the working tree has changes (checked via git status --porcelain). User config moved inside the conditional; no other steps or exports changed. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant GH as GitHub Actions Runner
participant Step as "Commit version files"
participant Git as git
GH->>Step: Execute step
Step->>Git: git status --porcelain
alt Changes detected
Step->>Git: git config user.name / user.email
Step->>Git: git add -A
Step->>Git: git commit -m "...version files"
Step->>Git: git push
Note right of Step: Commit/push only if there are modifications
else No changes
Step-->>GH: Skip git operations
Note right of Step: No-op branch
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Comment |
|
View your CI Pipeline Execution ↗ for commit 064d9f5
☁️ Nx Cloud last updated this comment at |
|
Sizes for commit 064d9f5:
|
🎯 Changes
Current workflow errors when there are no files to commit. It's also formatted incorrectly... oops
✅ Checklist
pnpm test:pr.🚀 Release Impact
Summary by CodeRabbit