fix(db): compile filter expression once instead of on every invocation#954
Merged
KyleAMathews merged 2 commits intomainfrom Dec 3, 2025
Merged
Conversation
Previously, `createFilterFunctionFromExpression` was calling `compileSingleRowExpression(expression)` inside the returned filter function, causing the expression to be recompiled for every item being filtered. This resulted in severe performance degradation when filtering large collections, as `normalizeValue` and other compilation functions were called thousands of times unnecessarily. Move the compilation outside the returned function so it happens once when the filter function is created.
🦋 Changeset detectedLatest commit: 4f4c021 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: +4 B (0%) Total Size: 87.1 kB
ℹ️ View Unchanged
|
f5f7425 to
e97fb96
Compare
Contributor
|
Size Change: 0 B Total Size: 3.35 kB ℹ️ View Unchanged
|
e97fb96 to
4f4c021
Compare
Merged
Contributor
|
🎉 This PR has been released! Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
createFilterFunctionFromExpressionwas callingcompileSingleRowExpression(expression)inside the returned filter function, causing the expression to be recompiled for every item being filtered.Move the compilation outside the returned function so it happens once when the filter function is created.
🎯 Changes
✅ Checklist
pnpm test:pr.🚀 Release Impact