Add timeout support to electric-db-collection#798
Merged
KyleAMathews merged 6 commits intomainfrom Nov 12, 2025
Merged
Conversation
This change allows users to specify a custom timeout when returning txids from mutation handlers (onInsert, onUpdate, onDelete). Previously, users could only customize timeouts when manually calling collection.utils.awaitTxId(), but not when using the automatic txid matching strategy via electricCollectionOptions. Changes: - Updated MatchingStrategy type to include optional timeout property - Modified processMatchingStrategy to extract and pass timeout to awaitTxId - Added documentation example showing how to use custom timeout - Updated JSDoc comments for mutation handlers This addresses the feature request in GitHub discussion #794. Default timeout remains 5000ms when not specified.
🦋 Changeset detectedLatest commit: fa9c3f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: 0 B Total Size: 86 kB ℹ️ View Unchanged
|
- Add new test to verify custom timeout in matching strategy - Test ensures timeout is properly passed to awaitTxId and triggers timeout error - Add changeset documenting the new timeout feature as a minor release All 60 tests passing including the new timeout test.
Contributor
|
Size Change: 0 B Total Size: 3.34 kB ℹ️ View Unchanged
|
b1dc988 to
893acda
Compare
Collaborator
Author
|
docs generation is being odd removing the links @kevin-dp any idea why that would happen? It just popped up in all the PRs today. |
Resolved conflicts: - packages/electric-db-collection/src/electric.ts: Combined timeout support with arrow function fix for array txids - packages/electric-db-collection/tests/electric.test.ts: Added both custom timeout test and array txid test The merge includes PR #795 which fixes array txid handling and is fully compatible with our timeout support feature. Our implementation passes the timeout parameter correctly to awaitTxId for both single and array cases.
Merged
Contributor
|
🎉 This PR has been released! Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows users to specify a custom timeout when returning txids from mutation handlers (onInsert, onUpdate, onDelete).
Previously, users could only customize timeouts when manually calling collection.utils.awaitTxId(), but not when using the automatic txid matching strategy via electricCollectionOptions.
Changes:
This addresses the feature request in GitHub discussion #794.
Default timeout remains 5000ms when not specified.
🎯 Changes
✅ Checklist
pnpm test:pr.🚀 Release Impact