Skip to content

Conversation

@stackloke2e
Copy link
Contributor

Summary

This PR updates the ToolHive API models generated from the latest OpenAPI specification.

Changes

  • Updated Pydantic models in src/mcp_optimizer/toolhive/api_models/

Notes

  • This PR was automatically generated by the update-thv-models workflow
  • The models are generated using datamodel-codegen from ToolHive's OpenAPI endpoint

🤖 Generated with GitHub Actions

Automated update of ToolHive API models from OpenAPI specification.
@claude
Copy link

claude bot commented Feb 10, 2026

PR Review: Update ToolHive API Models

Summary

Auto-generated PR updating Pydantic models from ToolHive's OpenAPI spec. Includes new modules and type renames.

Key Changes

  • New modules: authserver.py, skills.py, templates.py, upstreamswap.py (267 lines)
  • Renamed types: MCPClient to ClientApp, MCPClientStatus to ClientAppStatus
  • Removed field: virtual_mcp from Workload model
  • Enhanced models: KubernetesMetadata, cached token fields, header forwarding

Code Quality

  • Clean Pydantic models using native Python types (list, dict)
  • Proper Field() usage with descriptions
  • Consistent generation format

Potential Issues

  1. Breaking change: MCPClient renamed to ClientApp. Search codebase for usage.
  2. Breaking change: Workload.virtual_mcp field removed. Check if accessed.
  3. New enum values: gemini_cli, vs_code_server, mistral_vibe, codex added.
  4. UpdateRegistryResponse.message field removed.

Security

  • Auth config uses file/env var references (good)
  • OAuth caching uses secret references (good)

Recommendations

  • Search codebase for renamed/removed types
  • Test code using UpdateRegistryResponse or Workload.virtual_mcp
  • Verify new client enum values are handled

Overall: Well-structured code. Main concern is breaking changes from renames and removals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants