Implement Recipes by Maxqia · Pull Request #1027 · SpongePowered/Sponge

Maxqia · 2016-11-19T22:55:26Z

API | Common

kashike · 2016-11-19T23:06:03Z

src/main/java/org/spongepowered/common/mixin/core/item/recipe/MixinFurnaceRecipies.java

@@ -0,0 +1,47 @@
+package org.spongepowered.common.mixin.core.item.recipe;


Missing licence header.

kashike · 2016-11-19T23:06:18Z

src/main/java/org/spongepowered/common/mixin/core/item/recipe/MixinFurnaceRecipies.java

@@ -0,0 +1,47 @@
+package org.spongepowered.common.mixin.core.item.recipe;
+
+import java.util.Map;


Wrong import order.

kashike · 2016-11-19T23:06:22Z

src/main/java/org/spongepowered/common/mixin/core/item/recipe/MixinFurnaceRecipies.java

+import org.spongepowered.asm.mixin.Shadow;
+import org.spongepowered.common.item.inventory.util.ItemStackUtil;
+
+import net.minecraft.item.ItemStack;


Wrong import order.

kashike · 2016-11-19T23:06:34Z

src/main/java/org/spongepowered/common/mixin/core/item/recipe/MixinFurnaceRecipies.java

+
+    @Override
+    public boolean removeSmeltingRecipe(org.spongepowered.api.item.inventory.ItemStack input) {
+        ItemStack stack = smeltingList.remove(input);


kashike · 2016-11-19T23:07:24Z

src/main/java/org/spongepowered/common/mixin/core/item/recipe/MixinFurnaceRecipies.java

+
+    @Override
+    public org.spongepowered.api.item.inventory.ItemStack getMapping(org.spongepowered.api.item.inventory.ItemStack stack) {
+        return ItemStackUtil.cloneDefensive(smeltingList.get(stack));


kashike · 2016-11-19T23:07:28Z

src/main/java/org/spongepowered/common/mixin/core/item/recipe/MixinFurnaceRecipies.java

+
+    @Override
+    public float getExperience(org.spongepowered.api.item.inventory.ItemStack stack) {
+        return experienceList.get(stack);


liach · 2016-11-19T23:08:04Z

src/main/java/org/spongepowered/common/mixin/core/item/recipe/MixinFurnaceRecipies.java

+            if (experienceList.remove(stack) != null) {
+                return true;
+            }
+            throw new RuntimeException("It was in one map but not the other?");


throw new AssertionError("It was on one map but not the other.");

liach · 2016-11-19T23:12:57Z

src/main/java/org/spongepowered/common/mixin/core/item/recipe/MixinFurnaceRecipies.java

+
+    @Override
+    public void addSmeltingRecipe(org.spongepowered.api.item.inventory.ItemStack input, org.spongepowered.api.item.inventory.ItemStack output, float exp) {
+        addSmeltingRecipe(ItemStackUtil.toNative(input), ItemStackUtil.toNative(output), exp);


Is toNative simply for casting?

liach · 2016-11-19T23:13:44Z

Why do you never update submodule?

Maxqia · 2016-11-20T03:33:48Z

Now with more testing!
EDIT: removed itemstackutil changes

liach · 2016-11-20T04:19:46Z

src/main/java/org/spongepowered/common/mixin/core/item/recipe/MixinFurnaceRecipes.java

    @Override
-    public float getExperience(org.spongepowered.api.item.inventory.ItemStack stack) {
-        return this.experienceList.get(stack);
+    public Optional<Float> getExperience(org.spongepowered.api.item.inventory.ItemStack stack) {


There should be an OptionalDouble available in java.util.

That exists?!? ..., but it's kind of stupid, it always says it's present even if it's null

Limeth · 2017-01-01T20:10:16Z

src/main/java/org/spongepowered/common/item/recipe/SpongeSmeltingRecipe.java

+        checkNotNull(ingredient, "ingredient");
+        checkNotNull(result, "result");
+        checkNotNull(experience, "experience");
+        return this;


I am confused. This is not how builders are supposed to work.

liach · 2017-03-13T15:48:32Z

...in/java/org/spongepowered/common/item/recipe/crafting/SpongeShapedCraftingRecipeBuilder.java

+        return returnVal;
+    }
+
+    public static <T> ImmutableMap<T, ItemStackSnapshot> mapItemStackSnapshot(Map<T, ItemStack> map) {


These should move to util classes.

liach · 2017-03-13T15:50:49Z

src/main/java/org/spongepowered/common/mixin/core/item/recipe/MixinCraftingManager.java

+
+    @Override
+    public Optional<ImmutableCollection<ItemStackSnapshot>> getResults(GridInventory grid) {
+        throw new NotImplementedException("TODO"); // dunno how to convert a gridinventory to a IInventory...


liach · 2017-03-13T15:51:28Z

src/main/java/org/spongepowered/common/mixin/core/item/recipe/MixinIRecipe.java

+    @Shadow net.minecraft.item.ItemStack getRecipeOutput();
+
+    @Override
+    default ImmutableCollection<ItemStackSnapshot> getResults() {


Why are you using ImmutableCollection?

kashike · 2017-06-17T01:10:20Z

I'm going to close this in favour of #1395.

Maxqia mentioned this pull request Nov 19, 2016

Recipe Refactor SpongePowered/SpongeAPI#1419

Closed

kashike changed the title ~~[WIP] Implement Recipes~~ [WIP] Implement Furnace Recipes Nov 19, 2016

kashike added the type: enhancement An improvement label Nov 19, 2016

kashike suggested changes Nov 19, 2016

View reviewed changes

kashike self-assigned this Nov 19, 2016

liach reviewed Nov 19, 2016

View reviewed changes

kashike added the status: wip Work in progress label Nov 19, 2016

kashike changed the title ~~[WIP] Implement Furnace Recipes~~ Implement Furnace Recipes Nov 19, 2016

Maxqia force-pushed the recipe branch from 1d02650 to 826e309 Compare November 20, 2016 03:33

Maxqia force-pushed the recipe branch from 826e309 to eaa7805 Compare November 20, 2016 03:59

liach reviewed Nov 20, 2016

View reviewed changes

Maxqia force-pushed the recipe branch 2 times, most recently from fa10699 to 4473c32 Compare November 23, 2016 05:15

Maxqia force-pushed the recipe branch 3 times, most recently from c45c58e to 94a6073 Compare December 12, 2016 02:39

Limeth reviewed Jan 1, 2017

View reviewed changes

Maxqia force-pushed the recipe branch 4 times, most recently from fe40d11 to 9685e2f Compare January 3, 2017 09:19

Implement Smelting Recipes

6930c41

Maxqia force-pushed the recipe branch from 9685e2f to 6930c41 Compare January 3, 2017 09:43

Import Crafting Recipe Code

98d2fce

Maxqia changed the title ~~Implement Furnace Recipes~~ Implement Recipes Jan 3, 2017

Maxqia changed the title ~~Implement Recipes~~ [WIP] Implement Recipes Jan 3, 2017

It's working?

45facf1

Maxqia force-pushed the recipe branch from 32bab57 to 45facf1 Compare January 7, 2017 13:09

Predicates and Doubles

9163de1

Maxqia changed the title ~~[WIP] Implement Recipes~~ [Not WIP] Implement Recipes Jan 7, 2017

stephan-gh removed the status: wip Work in progress label Jan 7, 2017

stephan-gh changed the title ~~[Not WIP] Implement Recipes~~ Implement Recipes Jan 7, 2017

liach reviewed Mar 13, 2017

View reviewed changes

kashike closed this Jun 17, 2017

		@@ -0,0 +1,47 @@
		package org.spongepowered.common.mixin.core.item.recipe;

		@@ -0,0 +1,47 @@
		package org.spongepowered.common.mixin.core.item.recipe;

		import java.util.Map;

Uh oh!

Conversation

Maxqia commented Nov 19, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liach commented Nov 19, 2016

Uh oh!

Maxqia commented Nov 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liach Mar 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kashike commented Jun 17, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Maxqia commented Nov 19, 2016 •

edited

Loading

Maxqia commented Nov 20, 2016 •

edited

Loading

liach Mar 13, 2017 •

edited

Loading