Cap python 3.13 until we can remove the cap on numpy <2.0#3480
Merged
alejoe91 merged 4 commits intoSpikeInterface:mainfrom Nov 4, 2024
Merged
Cap python 3.13 until we can remove the cap on numpy <2.0#3480alejoe91 merged 4 commits intoSpikeInterface:mainfrom
alejoe91 merged 4 commits intoSpikeInterface:mainfrom
Conversation
zm711
reviewed
Oct 15, 2024
Co-authored-by: Zach McKenzie <92116279+zm711@users.noreply.github.com>
Member
|
I can't find our issue documenting github auth stuff being exceeded. Joe and I wanted to keep track of test failures due to not having a token which would greatly increase our limit. EDIT: my grammar was terrible. Fixed. Haha. |
Collaborator
Author
|
We should set the token! Let's do this on the next maintenance meeting. |
zm711
reviewed
Oct 20, 2024
Co-authored-by: Zach McKenzie <92116279+zm711@users.noreply.github.com>
alejoe91
approved these changes
Nov 4, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the meeting. @zm711 please correct if I got anything wrong
python 3.13 only supports numpy 2.0 on windows.
We can't support numpy 2.0 because of neo issues.
We are adding this temporary cap to avoid users getting a complicated error until we fix neo numpy 2.0 support.