Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes Node.js version specifications and updates the npm publish workflow configuration.
Changes:
- Standardized Node.js version format from string notation (e.g., '20.x') to numeric notation (e.g., 20)
- Added Node.js 24 to the test matrix
- Removed explicit NPM_TOKEN configuration from publish steps
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…: write is required for OIDC at the job level, not just the workflow level. Replaced JS-DevTools/npm-publish with direct npm publish commands — setup-node with registry-url configures npm to use OIDC, and direct npm publish will use that configuration.
…sure OIDC support.
….git to match the actual GitHub repository name.
Top-level permissions should not be required in conjunction with job-level permissions Co-authored-by: Jesse Wright <63333554+jeswr@users.noreply.github.com>
remove unneccessary job steps Co-authored-by: Jesse Wright <63333554+jeswr@users.noreply.github.com>
remove unneccessary steps Co-authored-by: Jesse Wright <63333554+jeswr@users.noreply.github.com>
|
@jeswr this has been on auto merge since yesterday |
|
You've changed the names of the build jobs by making the node variables 22 rather than 22.x. This means you'll need to update the names of the required job in the branch protections for this repo for this branch to merge. |
@jeswr I checked the settings, and I did not see any existing branch protections |
|
@PreciousOritsedere I removed not existing ones and added the new ones |
Fixes applied
Removed token authentication: ${{ secrets.NPM_TOKEN }} from the publish steps.
Added OIDC permissions: id-token: write at the workflow and job levels.
Updated npm version: Added npm install -g npm@latest to ensure npm >= 11.5.1 (required for OIDC).
Switched to direct npm publish: Replaced JS-DevTools/npm-publish with direct npm publish commands so npm uses the OIDC token from setup-node.
Fixed repository URL case: Updated package.json repository URL from git+https://github.com/solidos/solid-ui.git to git+https://github.com/SolidOS/solid-ui.git to match the GitHub repository name.