Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the solid-ui library build system and development workflow, dropping Node.js 18 support in favor of more modern tooling and ESM/UMD bundles.
- Replaced babel-based compilation with TypeScript, webpack for multiple bundle formats (UMD/ESM)
- Updated import/export statements from CommonJS to ES modules throughout the codebase
- Modernized configuration files and improved linting rules
Reviewed Changes
Copilot reviewed 123 out of 149 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| webpack.config.js | Complete rewrite to generate multiple bundle formats (UMD/ESM, minified/unminified, with/without rdflib) |
| package.json | Updated build scripts, dependencies, and main entry points for new build system |
| src/ files | Mass conversion from import * as ns to import ns and similar module import modernization |
| test/ files | Updated imports and removed unused variables to match new module system |
| config files | New babel.config.js, updated eslint.config.mjs, removed .babelrc |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is work done to improve different aspects of the library: