Conversation
Need changes that have been done to tabs.js
megoth
approved these changes
Jul 22, 2019
Contributor
megoth
left a comment
megoth
left a comment
There was a problem hiding this comment.
The amount of changes in this PR makes it nearly impossible to review properly. Most of the changes are done in outline/manager.js as well, which is excruciating to maintain because of its shear size and complexity.
That being said, I have managed to run this locally, and I trust Tim's insight into how these will affect the outcome.
(But we seriously need to improve our routines and testability if we want this code repo to be somewhat maintainable.)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal: fix bug that URKL bar not always set when should be
add login/out button on righthand side
add global nav menu when click on the login button a bit like github etc etc
also ... Remove UI.isExtension code as that was for an obsolete Firefox extension
Fixes #122.