fix: correct frontend asset paths#1796
Open
badzim wants to merge 1 commit intoSoftwareBrothers:masterfrom
Open
fix: correct frontend asset paths#1796badzim wants to merge 1 commit intoSoftwareBrothers:masterfrom
badzim wants to merge 1 commit intoSoftwareBrothers:masterfrom
Conversation
Author
|
@dziraf what do you think ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a path-resolution issue in the AdminJS router that causes all frontend bundles (
app.bundle.js,global.bundle.js,design-system.bundle.js) to return 404 when AdminJS is installed with pnpm, especially in monorepos or virtual store setups.Because the current code relies on
__dirname+ relative segments to locatelib/frontend/assets, the computed paths point to the wrong location under pnpm. As a result, the AdminJS UI does not load — this also affects the AdminJS demo site, which is currently down for the same reason.This PR replaces the brittle relative paths with robust module-resolution logic:
This approach works reliably across:
With this fix, all asset URLs under
/admin/frontend/assets/*resolve correctly again, and the AdminJS UI loads normally.