V3 : Fix GIF, PNG, and WEBP Edge Case Handling#2882
Merged
JimBobSquarePants merged 29 commits intorelease/3.1.xfrom Mar 27, 2025
Merged
V3 : Fix GIF, PNG, and WEBP Edge Case Handling#2882JimBobSquarePants merged 29 commits intorelease/3.1.xfrom
JimBobSquarePants merged 29 commits intorelease/3.1.xfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 16 changed files in this pull request and generated no comments.
Files not reviewed (11)
- tests/Images/External/ReferenceOutput/GifDecoderTests/Issue1962_Rgba32_issue1962_tiniest_gif_1st.png: Language not supported
- tests/Images/External/ReferenceOutput/GifDecoderTests/Issue2012BadMinCode_Rgba32_issue2012_drona1.png: Language not supported
- tests/Images/Input/Gif/issues/issue_2866.gif: Language not supported
- tests/Images/Input/Webp/issues/Issue2866.webp: Language not supported
- src/ImageSharp/Formats/Gif/GifEncoderCore.cs: Evaluated as low risk
- tests/ImageSharp.Tests/TestUtilities/ReferenceCodecs/MagickReferenceDecoder.cs: Evaluated as low risk
- src/ImageSharp/Formats/Webp/Lossy/Vp8Decoder.cs: Evaluated as low risk
- src/ImageSharp/Formats/Webp/BitReader/BitReaderBase.cs: Evaluated as low risk
- tests/ImageSharp.Tests/Formats/Png/PngEncoderTests.cs: Evaluated as low risk
- tests/ImageSharp.Tests/TestImages.cs: Evaluated as low risk
- src/ImageSharp/Formats/Webp/WebpBlendMethod.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)
tests/ImageSharp.Tests/Formats/Gif/GifEncoderTests.cs:389
- [nitpick] The test method name GifEncoder_CanDecode_Issue2866 is misleading since it is testing encoding, not decoding. It should be renamed to GifEncoder_CanEncode_Issue2866.
public void GifEncoder_CanDecode_Issue2866<TPixel>(TestImageProvider<TPixel> provider)
src/ImageSharp/Formats/Webp/WebpAnimationDecoder.cs:89
- The comment should reflect the correct type for backgroundColor, which is TPixel instead of Color.
/// <param name="backgroundColor">The default background color of the canvas in.</param>
Member
|
This is quite a huge change, but I'm planning to take a high-level look in the coming days. |
Member
Author
Thanks! I have a V4 version also that I’m going to push, lots of similarities but also some additional changes. |
4 tasks
This was referenced Nov 17, 2025
This was referenced Nov 25, 2025
This was referenced Dec 3, 2025
This was referenced Dec 10, 2025
This was referenced Dec 18, 2025
This was referenced Dec 29, 2025
This was referenced Jan 6, 2026
This was referenced Jan 15, 2026
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fixes #2866
Fixes #2862
There's quite a lot going on here:
I'll have to manually rework this for V4 as the code base has migrated significantly there.