Skip to content

Enable RuboCop style cops #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rafaelfranca wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enable RuboCop style cops #766

rafaelfranca wants to merge 3 commits into from

Conversation

@rafaelfranca
Copy link
Member

@rafaelfranca rafaelfranca commented Nov 4, 2025 •
edited
Loading

@rafaelfranca rafaelfranca requested a review from a team as a code owner November 4, 2025 22:47
@github-actions github-actions bot added the config change Changes the Rubocop config by enabling, disabling, or reconfiguring one or many cops label Nov 4, 2025
@rafaelfranca rafaelfranca force-pushed the rm-style-department branch 2 times, most recently from 80bf467 to 712cb31 Compare November 4, 2025 23:44
burke
burke reviewed Nov 5, 2025
View reviewed changes
burke
burke reviewed Nov 5, 2025
View reviewed changes
burke
burke reviewed Nov 5, 2025
View reviewed changes
hmcguire-shopify
hmcguire-shopify reviewed Nov 6, 2025
View reviewed changes
hmcguire-shopify
hmcguire-shopify reviewed Nov 6, 2025
View reviewed changes
@rafaelfranca rafaelfranca force-pushed the rm-style-department branch 2 times, most recently from db360a6 to 7845d49 Compare November 6, 2025 21:59
@rafaelfranca
Copy link
Member Author

rafaelfranca commented Nov 12, 2025

Removed Style/BisectedAttrAccessor because it conflicts with Sorbet

@rafaelfranca
Enable RuboCop style cops
f7fafa3 
- enable [Style/AmbiguousEndlessMethodDefinition](https://docs.rubocop.org/rubocop/cops_style.html#styleambiguousendlessmethoddefinition)
- enable [Style/AndOr](https://docs.rubocop.org/rubocop/cops_style.html#styleandor)
- enable [Style/ArrayCoercion](https://docs.rubocop.org/rubocop/cops_style.html#stylearraycoercion)
- enable [Style/Attr](https://docs.rubocop.org/rubocop/cops_style.html#styleattr)
- enable [Style/BisectedAttrAccessor](https://docs.rubocop.org/rubocop/cops_style.html#stylebisectedattraccessor)
- enable [Style/BlockComments](https://docs.rubocop.org/rubocop/cops_style.html#styleblockcomments)
- enable [Style/CharacterLiteral](https://docs.rubocop.org/rubocop/cops_style.html#stylecharacterliteral)
- enable [Style/ClassAndModuleChildren](https://docs.rubocop.org/rubocop/cops_style.html#styleclassandmodulechildren)
- enable [Style/ClassMethodsDefinitions](https://docs.rubocop.org/rubocop/cops_style.html#styleclassmethodsdefinitions)
- enable [Style/ClassMethods](https://docs.rubocop.org/rubocop/cops_style.html#styleclassmethods)
- enable [Style/ClassVars](https://docs.rubocop.org/rubocop/cops_style.html#styleclassvars)
- enable [Style/ColonMethodCall](https://docs.rubocop.org/rubocop/cops_style.html#stylecolonmethodcall)
- enable [Style/ColonMethodDefinition](https://docs.rubocop.org/rubocop/cops_style.html#stylecolonmethoddefinition)
- enable [Style/CombinableDefined](https://docs.rubocop.org/rubocop/cops_style.html#stylecombinabledefined)
- enable [Style/DateTime](https://docs.rubocop.org/rubocop/cops_style.html#styledatetime)
- enable [Style/DefWithParentheses](https://docs.rubocop.org/rubocop/cops_style.html#styledefwithparentheses)
- enable [Style/DigChain](https://docs.rubocop.org/rubocop/cops_style.html#styledigchain)
- enable [Style/EndlessMethod](https://docs.rubocop.org/rubocop/cops_style.html#styleendlessmethod)
- enable [Style/GlobalVars](https://docs.rubocop.org/rubocop/cops_style.html#styleglobalvars)
- enable [Style/HashSyntax](https://docs.rubocop.org/rubocop/cops_style.html#stylehashsyntax)
- enable [Style/MagicCommentFormat](https://docs.rubocop.org/rubocop/cops_style.html#stylemagiccommentformat)
- enable [Style/MethodDefParentheses](https://docs.rubocop.org/rubocop/cops_style.html#stylemethoddefparentheses)
- enable [Style/RedundantBegin](https://docs.rubocop.org/rubocop/cops_style.html#styleredundantbegin)
- enable [Style/RedundantReturn](https://docs.rubocop.org/rubocop/cops_style.html#styleredundantreturn)
- enable [Style/RedundantSelf](https://docs.rubocop.org/rubocop/cops_style.html#styleredundantself)
- enable [Style/Semicolon](https://docs.rubocop.org/rubocop/cops_style.html#stylesemicolon)
- enable [Style/SymbolLiteral](https://docs.rubocop.org/rubocop/cops_style.html#stylesymbolliteral)
- enable [Style/TrailingBodyOnClass](https://docs.rubocop.org/rubocop/cops_style.html#styletrailingbodyonclass)
- enable [Style/TrailingBodyOnMethodDefinition](https://docs.rubocop.org/rubocop/cops_style.html#styletrailingbodyonmethoddefinition)
- enable [Style/TrailingBodyOnModule](https://docs.rubocop.org/rubocop/cops_style.html#styletrailingbodyonmodule)
- enable [Style/TrailingMethodEndStatement](https://docs.rubocop.org/rubocop/cops_style.html#styletrailingmethodendstatement)
- enable [Style/UnlessElse](https://docs.rubocop.org/rubocop/cops_style.html#styleunlesselse)
- enable [Style/VariableInterpolation](https://docs.rubocop.org/rubocop/cops_style.html#stylevariableinterpolation)
@rafaelfranca
Disable Style/BisectedAttrAccessor
7b8a1d8 
It conflicts with Sorbet signatures.
@rafaelfranca
Disable Style/RedundantSelf
2ac79ae 
It conflicts with RBS inline comments.

For example:

```
self #: as untyped
  .some_method
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hmcguire-shopify hmcguire-shopify hmcguire-shopify left review comments

@burke burke burke approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

config change Changes the Rubocop config by enabling, disabling, or reconfiguring one or many cops

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rafaelfranca @burke @hmcguire-shopify