Add /listings folder to theme package command#6002
Conversation
|
Can't seem to sign the CLA. When I click "submit" I get:
|
|
Thanks, @chrisberthe! I'll raise to the team about the CLA. |
|
@chrisberthe please try again! You should be good to go now. |
|
I have signed the CLA! |
|
@graygilmore seems like most of the failing actions are a broader CLI thing? |
91bee02 to
71f4149
Compare
|
Very weird! Can you try rebasing with |
|
Odd indeed—I had rebased off |
|
@chrisberthe thanks for bearing with me on this. Looks like there's one legit failure and then we'll be good to go. You can run the tests locally with |
71f4149 to
8781a1d
Compare
8781a1d to
9b52391
Compare
|
Thanks @graygilmore for spotting that. Should be good now :) |
shopify theme packagecommand excludes/listings/directories from output ZIP #5975WHY are these changes introduced?
Shopify introduced new requirements for the Shopify Theme Store that require themes with multiple presets to include a
/listingsdirectory in their theme zip submissions.WHAT is this pull request doing?
/listings/**pattern to include the listings directory in theme packagesHow to test your changes?
/listingsfolder to themeshopify theme packagein theme directory/listingsdirectoryMeasuring impact
How do we know this change was effective? Please choose one:
Checklist