use league_rank as loop control var

[cwsmith]

There were nested loops reusing i and given the length of the loop body, I think this helps readability.

All tests are passing on the SCOREC checkers workstation with the following cmake config. DEVICE_ARCH is set to AMPERE86.

export NVCC_WRAPPER_DEFAULT_COMPILER=`which mpicxx`

bdir=$DEPENDENCY_DIR/${DEVICE_ARCH}/pcms
set -x
cmake --debug-find-pkg=meshfields -S pcms -B $bdir \
  -DCMAKE_INSTALL_PREFIX=$bdir/install \
  -DCMAKE_CXX_COMPILER=`which mpicxx` \
  -DCMAKE_C_COMPILER=`which mpicc` \
  -DCMAKE_BUILD_TYPE=Release \
  -DOmega_h_DIR=$DEPENDENCY_DIR/${DEVICE_ARCH}/omega_h/install/lib64/cmake/Omega_h/ \
  -Dredev_DIR=$DEPENDENCY_DIR/${DEVICE_ARCH}/redev/install/lib64/cmake/redev/ \
  -DPCMS_TEST_DATA_DIR=pcms_testcases \
  -DMPIEXEC_EXECUTABLE=`which mpirun` \
  -DKokkos_DIR=$DEPENDENCY_DIR/${DEVICE_ARCH}/kokkos/install/lib64/cmake/Kokkos/ \
  -DKokkosKernels_DIR=$DEPENDENCY_DIR/${DEVICE_ARCH}/kokkos-kernels/install/lib64/cmake/KokkosKernels/ \
  -DPCMS_ENABLE_MESHFIELDS=on \
  -Dmeshfields_DIR=$DEPENDENCY_DIR/${DEVICE_ARCH}/meshfields_caboff/install/lib64/cmake/meshfields \
  -DBUILD_TESTING=ON

cmake --build $bdir --target install -j20
set +x

[jacobmerson]

Good catch.