Skip to content

make SupportResults struct readonly#156

Merged
cwsmith merged 1 commit intomls_interpolationfrom
cws/SupportStructReadOnly
Feb 11, 2025
Merged

make SupportResults struct readonly#156
cwsmith merged 1 commit intomls_interpolationfrom
cws/SupportStructReadOnly

Conversation

@cwsmith
Copy link
Contributor

@cwsmith cwsmith commented Feb 10, 2025

This PR makes the CSR stored in the SupportResults struct read only.

Note, I'm not sure what should be done with the radii2 member of the struct. Should it be removed?

All tests are passing on the SCOREC checkers workstation with the following cmake config. DEVICE_ARCH is set to AMPERE86.

export NVCC_WRAPPER_DEFAULT_COMPILER=`which mpicxx`

bdir=$DEPENDENCY_DIR/${DEVICE_ARCH}/pcms
set -x
cmake --debug-find-pkg=meshfields -S pcms -B $bdir \
  -DCMAKE_INSTALL_PREFIX=$bdir/install \
  -DCMAKE_CXX_COMPILER=`which mpicxx` \
  -DCMAKE_C_COMPILER=`which mpicc` \
  -DCMAKE_BUILD_TYPE=Release \
  -DOmega_h_DIR=$DEPENDENCY_DIR/${DEVICE_ARCH}/omega_h/install/lib64/cmake/Omega_h/ \
  -Dredev_DIR=$DEPENDENCY_DIR/${DEVICE_ARCH}/redev/install/lib64/cmake/redev/ \
  -DPCMS_TEST_DATA_DIR=pcms_testcases \
  -DMPIEXEC_EXECUTABLE=`which mpirun` \
  -DKokkos_DIR=$DEPENDENCY_DIR/${DEVICE_ARCH}/kokkos/install/lib64/cmake/Kokkos/ \
  -DKokkosKernels_DIR=$DEPENDENCY_DIR/${DEVICE_ARCH}/kokkos-kernels/install/lib64/cmake/KokkosKernels/ \
  -DPCMS_ENABLE_MESHFIELDS=on \
  -Dmeshfields_DIR=$DEPENDENCY_DIR/${DEVICE_ARCH}/meshfields_caboff/install/lib64/cmake/meshfields \
  -DBUILD_TESTING=ON

cmake --build $bdir --target install -j20
set +x

I'm not sure what should be done with the radii2 member of the struct.
Copy link
Collaborator

@jacobmerson jacobmerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @abhiyanpaudel If you don't have any issues I will merge.

@abhiyanpaudel
Copy link
Collaborator

Looks good to me. @abhiyanpaudel If you don't have any issues I will merge.

sure, you can merge

@cwsmith cwsmith merged commit 73bbd2a into mls_interpolation Feb 11, 2025
1 check passed
@cwsmith cwsmith deleted the cws/SupportStructReadOnly branch February 11, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants