make SupportResults struct readonly#156
Merged
cwsmith merged 1 commit intomls_interpolationfrom Feb 11, 2025
Merged
Conversation
I'm not sure what should be done with the radii2 member of the struct.
jacobmerson
reviewed
Feb 10, 2025
Collaborator
jacobmerson
left a comment
There was a problem hiding this comment.
Looks good to me. @abhiyanpaudel If you don't have any issues I will merge.
Collaborator
sure, you can merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the CSR stored in the
SupportResultsstruct read only.Note, I'm not sure what should be done with the radii2 member of the struct. Should it be removed?
All tests are passing on the SCOREC checkers workstation with the following cmake config.
DEVICE_ARCHis set toAMPERE86.