DynLogEnvironment - Also wrap configuration with a LazyInitializer.#182
Merged
KarstenSchnitter merged 1 commit intoSAP:mainfrom Jul 9, 2024
Merged
Conversation
* In the default flow it is not necessary. But since the DynamicLogLevelConfiguration is also exposed via the protected getConfiguration(), it is recreated on each invocation.
KarstenSchnitter
approved these changes
Jul 5, 2024
Contributor
KarstenSchnitter
left a comment
KarstenSchnitter
left a comment
There was a problem hiding this comment.
Thanks for providing this change. This seems to be rather hard to notice. Thanks for doing so. Note, that this code will change in 4.x, where the configuration will be imported via SPI. For now, this is not yet implemented.
Contributor
Contributor
Author
|
@KarstenSchnitter Whenever it fits best for you. I do not depend on this fix and provided a PR to point out/correct it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DynLogEnvironment - Also wrap configuration with a LazyInitializer.
In the default flow, the wrapping would not be necessary. But since the
DynamicLogLevelConfigurationis also exposed viaprotected Optional<DynamicLogLevelConfiguration> getConfiguration(), it is recreated on each invocation.(Another solution would be to remove getConfiguration(), but this is breaking API contracts)