Fix primes on RSA key conversion#318
Merged
tarcieri merged 1 commit intoRustCrypto:stablefrom Mar 26, 2025
Merged
Conversation
Shoutout to @dignifiedquire for finding the issue
Contributor
|
It's same as #218 so I guess it just needs a backport to the stable release |
Eugeny
added a commit
to Eugeny/RustCrypto-SSH
that referenced
this pull request
Dec 28, 2024
Eugeny
added a commit
to Eugeny/RustCrypto-SSH
that referenced
this pull request
Dec 29, 2024
zydou
pushed a commit
to zydou/arti
that referenced
this pull request
Mar 16, 2026
Upstream `ssh-key` is missing some important features we need for
arti-relay:
* a bug fix without which we can't convert deserialized RSA keys to
their rsa counterparts: RustCrypto/SSH#318
* @WesleyAC 's patch RustCrypto/SSH#412 for
allowing insecure (1024 bits long) RSA keys (needed because the
relay KS_relayid_rsa identity keys are 1024 bits long)
We plan to switch back to mainline `ssh-key` when `ssh-key 0.7.0` comes
out.
See the discussion in #2398 for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shoutout to @dignifiedquire for finding the issue in RustCrypto/RSA#463