Panic structurization improvements#20
Merged
LegNeato merged 4 commits intoRust-GPU:mainfrom Oct 18, 2024
Merged
Conversation
Firestar99
force-pushed
the
panic-structurization
branch
from
9d01faa to
b2df554
Compare
LegNeato
approved these changes
Oct 18, 2024
Collaborator
LegNeato
left a comment
LegNeato
left a comment
There was a problem hiding this comment.
I'm not really qualified to review this 😂
Member
Author
|
Me neither, really, way too deep in compiler code. But it works fine in my project, so feel free to hit that merge button :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves structurization of panics and other functions that exit the invocation, like
OpKill(discard;in glsl) in fragment shaders. This should hopefully reduce the amount of structurization errors in the resulting spv.Mainly developed by @eddyb with some test fixes by @LegNeato