cuda_std_macros: remove KernelHints.
#340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `#[kernel]` proc macro has some code to allow "kernel hints"
arguments like this:
```
#[kernel(block_dim = 1d, grid_dim = 1d)]
```
This dates back to the very first rust-cuda commit. However...
- The parsing code is broken. It requires an identifier after the `=`,
and then checks that identifier has one of the following values: `1d`,
`1D`, `2d`, `2D`, `3d`, `3D`. But those aren't valid identifiers
because they start with a digit. So you can't actually write any
kernel hints that the compiler will accept.
- Even if the parsing succeeded, the hints are ignored, thanks to this:
```
let _ = parse_macro_input!(input as KernelHints);
```
- Unsurprisingly, there are no uses of these hints in the code.
This commit just removes the (broken) support for them.
nnethercote
force-pushed
the
rm-KernelHints
branch
from
83337a4 to
bce1a0b
Compare
LegNeato
approved these changes
Dec 11, 2025
Contributor
LegNeato
left a comment
LegNeato
left a comment
There was a problem hiding this comment.
This is probably better as an arch intrinsic...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
#[kernel]proc macro has some code to allow "kernel hints" arguments like this:This dates back to the very first rust-cuda commit. However...
The parsing code is broken. It requires an identifier after the
=, and then checks that identifier has one of the following values:1d,1D,2d,2D,3d,3D. But those aren't valid identifiers because they start with a digit. So you can't actually write any kernel hints that the compiler will accept.Even if the parsing succeeded, the hints are ignored, thanks to this:
let _ = parse_macro_input!(input as KernelHints);Unsurprisingly, there are no uses of these hints in the code.
This commit just removes the (broken) support for them.