Skip to content

Fix issue #114 (Support for EndroidQR v5)#115

Merged
willpower232 merged 5 commits intoRobThree:masterfrom
Mattie112:endroidqr-v5
Nov 14, 2023
Merged

Fix issue #114 (Support for EndroidQR v5)#115
willpower232 merged 5 commits intoRobThree:masterfrom
Mattie112:endroidqr-v5

Conversation

@Mattie112
Copy link
Copy Markdown
Contributor

The new version is using PHP ENUMs, added a check to make it compatible with v5.

Should also still work for v4 (and older)!

Tested with endroid/qr-code v4.8.5 and v5.0.2 with both versions I can generate a QR code.

            $qr_provider = new EndroidQrCodeProvider();
            $tfa = new TwoFactorAuth("xx", qrcodeprovider: $qr_provider);
            $qr = $tfa->getQRCodeImageAsDataUri("uid", $secret);

@willpower232 willpower232 merged commit ab93dd4 into RobThree:master Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants