Fix badges in README#102
Merged
willpower232 merged 2 commits intoRobThree:masterfrom Feb 27, 2023
NicolasCARPi:badges
Merged
Conversation
willpower232
approved these changes
Feb 25, 2023
Collaborator
willpower232
left a comment
willpower232
left a comment
There was a problem hiding this comment.
yes they seem to have changed the badge URL at some point and they also hate the number of arguments in some of the constructor methods so if @RobThree has no particular attachment to codeclimate (or no desire to resolve the problem one way or the other) this sounds good
Owner
|
@willpower232 No particular attachement. Also I'd like to, again, thank you for your work and picking up my slack. It's much appreciated! |
Collaborator
|
not a problem at all, I've got plenty of mouse clicks to go round 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix build badge, see: badges/shields#8671
remove codeclimate badge because it's not working and no coverage appears there anyway. I think codeclimate provides its own badge url but this can only be accessed with credentials IIRC.