Refactor platform reexports into explicit reexports#199
Merged
rolandszoke merged 1 commit intoRisingStack:tempfrom Jan 25, 2021
orballo:named-exports
Merged
Refactor platform reexports into explicit reexports#199rolandszoke merged 1 commit intoRisingStack:tempfrom orballo:named-exports
rolandszoke merged 1 commit intoRisingStack:tempfrom
orballo:named-exports
Conversation
Member
|
@orballo Thanks for the fix! 🚀 We will merge your commits to the temp branch along with other changes, so we can make sure everything works fine (tests and build process), and eventually (probably this week) we will release it to alpha. |
rolandszoke
approved these changes
Jan 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Refactor reexports from
platforms/dom.jsandplatforms/native.jsinto explicit reexports.Why
While trying to build my project with
parcelandrollupI run into a situation where the bundlers cannot resolve the exports of these files. It has been a bit of a pain. As far as I know,parceldoesn't allow to manually fix this. On the other hand,rollupused to allow a manual fix with an option callednamedExportswhich was deprecated in recent versions and it's no longer available.Here is an example of the error I get from
parcel(note: this only happens with parcel when using the--experimental-scope-hoistingflag, or withparcel v2):Regarding
rollupI found this issue (rollup/rollup#2671). After asking, they suggested that all the reexports should be explicit to avoid this kind of problems.I'm not sure if this is the ideal solution (I wasn't able to fix it in any other way, though), but if it has no downsides, this changes will at least prevent some pain.
Let me know what you think or if I need to do any further changes.