Improve Android clustering performance by batching#1
Merged
Conversation
Collaborator
Author
|
I used copilot to apply the same strategy from the web PR to the android code. |
Collaborator
Author
|
Currently doing some draft testing, and once we have confirmation that this is working will submit an upstream PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on flutter#10562
Changes Made:
Performance Impact
This fix eliminates the expensive cluster() call that was happening after each individual marker operation. With 2000+ markers, this reduces:
Test Results
✅ All Android unit tests pass (78 tests)
✅ All Dart tests pass (51 tests)
✅ Code formatting passes
✅ Static analysis passes
The implementation is complete and ready for use! This should resolve the performance issues you're experiencing with marker clustering on Android when dealing with large numbers of markers (>2000).