feat: add allow_workload_disruption parameter to MigrationPolicy

[SamAlber]

Short description:

KubeVirt introduced AllowWorkloadDisruption in the MigrationPolicySpec. This field controls migration behavior when migrations exceed AcceptableCompletionTime: the controller can pause the VMI or switch to post-copy to force completion.

More details:

The AllowWorkloadDisruption option dictates behavior after the AcceptableCompletionTime threshold is reached. When activated with allowPostCopy=true, the migration controller switches to post-copy mode.
When allowPostCopy=false, the controller pauses the VMI to allow migration to complete safely without risk of data loss.

For backward compatibility, if AllowWorkloadDisruption is not explicitly set but AllowPostCopy is, AllowWorkloadDisruption implicitly inherits the value of AllowPostCopy.

What this PR does / why we need it:

Adds the allow_workload_disruption (bool, optional) parameter to the MigrationPolicy class, serialized as allowWorkloadDisruption in the spec. This allows consumers of the wrapper to create MigrationPolicy resources that use the new pause-to-migrate feature

Upstream feature PR: kubevirt/kubevirt#11833

Summary by CodeRabbit

• New Features
  • Migration policies now support an optional configuration to control workload disruption behavior during migrations, giving users greater flexibility in managing migration operations.

[redhat-qe-bot]

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

• Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
• Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
• Issue Creation: Disabled for this repository
• Branch Labeling: Branch-specific labels are applied to track the target branch
• Auto-verification: Auto-verified users have their PRs automatically marked as verified
• Labels: All label categories are enabled (default configuration)

📋 Available Commands

PR Status Management

• /wip - Mark PR as work in progress (adds WIP: prefix to title)
• /wip cancel - Remove work in progress status
• /hold - Block PR merging (approvers only)
• /hold cancel - Unblock PR merging
• /verified - Mark PR as verified
• /verified cancel - Remove verification status
• /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
• /regenerate-welcome - Regenerate this welcome message

Review & Approval

• /lgtm - Approve changes (looks good to me)
• /approve - Approve PR (approvers only)
• /automerge - Enable automatic merging when all requirements are met (maintainers and approvers only)
• /assign-reviewers - Assign reviewers based on OWNERS file
• /assign-reviewer @username - Assign specific reviewer
• /check-can-merge - Check if PR meets merge requirements

Testing & Validation

• /retest tox - Run Python test suite with tox
• /retest python-module-install - Test Python package installation
• /retest conventional-title - Validate commit message format
• /retest all - Run all available tests

Cherry-pick Operations

• /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
  • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

• /<label-name> - Add a label to the PR
• /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

1. Approval: /approve from at least one approver
2. Status Checks: All required status checks must pass
3. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
4. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

• myakove
• rnetser

Reviewers:

• myakove
• rnetser

Available Labels

• hold
• verified
• wip
• lgtm
• approve
• automerge

💡 Tips

• WIP Status: Use /wip when your PR is not ready for review
• Verification: The verified label is automatically removed on each new commit
• Cherry-picking: Cherry-pick labels are processed when the PR is merged
• Permission Levels: Some commands require approver permissions
• Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

[coderabbitai]

Warning

Rate limit exceeded

@SamAlber has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 20 minutes and 52 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2c4748a1-a75b-4d78-b6cc-878fed976e54

📥 Commits

Reviewing files that changed from the base of the PR and between 3dedff0 and 8e8b12b.

📒 Files selected for processing (1)

• ocp_resources/migration_policy.py

Walkthrough

Added optional allow_workload_disruption field to MigrationPolicy class with constructor integration and serialization support via to_dict method.

Changes

Cohort / File(s)	Summary
MigrationPolicy Enhancement ocp_resources/migration_policy.py	Added optional allow_workload_disruption field with constructor parameter, instance attribute storage, and conditional inclusion in dict serialization when non-null.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and specifically summarizes the main change—adding the allow_workload_disruption parameter to MigrationPolicy, which directly matches the changeset content.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The pull request description is comprehensive and well-structured, covering all major template sections with clear, technical details about the feature, its purpose, and implementation.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[myakove]

/lgtm
/approve

@SamAlber please rebase and verify

[SamAlber]

/verified

Added parameter in the .venv of the openshift-virtualization-tests repo and ran the new test locally with the new MigrationPolicy.

[rnetser]

/approve
/lgtm