Skip to content

CherryPicked: [v4.20] feat: ocp_resource plan - Add a few missing parameters#2651

Merged
redhat-qe-bot2 merged 1 commit intov4.20from
CherryPicked-mtv_plan-37Em6
Feb 16, 2026
Merged

CherryPicked: [v4.20] feat: ocp_resource plan - Add a few missing parameters#2651
redhat-qe-bot2 merged 1 commit intov4.20from
CherryPicked-mtv_plan-37Em6

Conversation

@redhat-qe-bot
Copy link
Contributor

cherry-pick #2545 into v4.20

requested-by servolkov

- pvcNameTemplate
- volumeNameTemplate
- networkNameTemplate
- preserveStaticIPs
- targetNodeSelector
- targetLabels
- targetAffinity

Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
@coderabbitai
Copy link

coderabbitai bot commented Feb 14, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch CherryPicked-mtv_plan-37Em6

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@redhat-qe-bot2
Copy link

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

Note: You are an auto-verified user. Your PRs will be automatically verified and may be auto-merged when all requirements are met.

🔄 Automatic Actions

  • Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
  • Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
  • Issue Creation: Disabled for this repository
  • Branch Labeling: Branch-specific labels are applied to track the target branch
  • Auto-verification: Auto-verified users have their PRs automatically marked as verified
  • Labels: All label categories are enabled (default configuration)

📋 Available Commands

PR Status Management

  • /wip - Mark PR as work in progress (adds WIP: prefix to title)
  • /wip cancel - Remove work in progress status
  • /hold - Block PR merging (approvers only)
  • /hold cancel - Unblock PR merging
  • /verified - Mark PR as verified
  • /verified cancel - Remove verification status
  • /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
  • /regenerate-welcome - Regenerate this welcome message

Review & Approval

  • /lgtm - Approve changes (looks good to me)
  • /approve - Approve PR (approvers only)
  • /automerge - Enable automatic merging when all requirements are met (maintainers and approvers only)
  • /assign-reviewers - Assign reviewers based on OWNERS file
  • /assign-reviewer @username - Assign specific reviewer
  • /check-can-merge - Check if PR meets merge requirements

Testing & Validation

  • /retest tox - Run Python test suite with tox
  • /retest python-module-install - Test Python package installation
  • /retest conventional-title - Validate commit message format
  • /retest all - Run all available tests

Cherry-pick Operations

  • /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
    • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

  • /<label-name> - Add a label to the PR
  • /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

  1. Approval: /approve from at least one approver
  2. LGTM Count: Minimum 0 /lgtm from reviewers
  3. Status Checks: All required status checks must pass
  4. No Blockers: No WIP, hold, conflict labels
  5. Verified: PR must be marked as verified (if verification is enabled)

📊 Review Process

Approvers and Reviewers

Approvers:

  • myakove
  • rnetser

Reviewers:

  • dbasunag
  • myakove
  • rnetser
Available Labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
  • automerge

💡 Tips

  • WIP Status: Use /wip when your PR is not ready for review
  • Verification: The verified label is automatically removed on each new commit
  • Cherry-picking: Cherry-pick labels are processed when the PR is merged
  • Permission Levels: Some commands require approver permissions
  • Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

@servolkov
Copy link
Contributor

Verified here.

@myakove
Copy link
Collaborator

myakove commented Feb 16, 2026

/lgtm
/approve

@redhat-qe-bot2 redhat-qe-bot2 merged commit da344ee into v4.20 Feb 16, 2026
7 checks passed
@redhat-qe-bot2 redhat-qe-bot2 deleted the CherryPicked-mtv_plan-37Em6 branch February 16, 2026 07:22
rnetser added a commit to RedHatQE/openshift-virtualization-tests that referenced this pull request Feb 17, 2026
Manual cherry-pick of
#2970,
#3564
into cnv-4.20 branch.

Due to some code discrepancies with the `main`, it was added
`pytest-subtests` dependency, and some imports were fixed. Also timeout
for `Plan` resource creation has been increased: behind the scene during
resource creation some images are downloaded to the cluster nodes, I was
observing the case when it took ~2 min on my local environment, the
current 60 sec timeout might be not enough.

**Depends on**:
RedHatQE/openshift-python-wrapper#2651

##### jira-ticket: https://issues.redhat.com/browse/CNV-69307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants