Make byLine handle carriage newline and just newline equally.#31
Make byLine handle carriage newline and just newline equally.#31abersnaze merged 1 commit intoReactiveX:1.xfrom
Conversation
|
You may want to handle \r only too as if I remember correctly, Mac OS 9 has only \r as a new line separator. |
|
I don't know if I even want to think about what it would take to support running RxJava on what ever version of the JDK on OS 9. I'll think about regex though. |
|
I'm not supposing it would run on OS 9 just that a file may be originating from there (for instance, reading a client's file who runs on an old OS 9) |
|
@Crystark I got all three line ending forms able to coexist in one regex. If you could give a 👍 I'll merge it. |
|
It seems OK to me. Although I would write the pattern like that: Thanks alot. |
|
@Crystark made additional changes to the regex to include all of the line terminating characters as listed in java.util.Pattern |
|
👍 |
Make byLine handle carriage newline and just newline equally.
based on a discussion on #30.