changed classnames module with clsx#1064
Conversation
|
Thanks for the great suggestion. Personally, I'd leave this open and merge whenever we either launch v6 (probably a few months down the road), or make some other bigger changes which would make sense to include this one. It probably wouldn't be that big of a deal overall, but it just feels weird to randomly switch out an entire package on a minor version just to save on 100-some bytes of bundlesize (if there were a breaking bug or something like that, it would be a different story). |
|
Might I suggest also changing the object style classes with the boolean comparison ones for a sligh performance boost clsx bench? E.g. change clsx('react-tooltip-arrow',
coreStyles['arrow'],
styles['arrow'],
classNameArrow,
{ [coreStyles['noArrow']]: noArrow, }
)To this: clsx('react-tooltip-arrow',
coreStyles['arrow'],
styles['arrow'],
classNameArrow,
noArrow && coreStyles['noArrow']) |
|
Hi guys, We will start the development of V6 in our available time, so I created a new branch and I changed the target of this PR from Can you guys please fix the conflicts? This should be merged soon. Thanks! |
This PR changes
classnamesdependecy toclsx- smaller and newer alternativehttps://github.com/lukeed/clsx