Skip to content

Fix frollapply to handle n > len case#7650

Open
jangorecki wants to merge 4 commits intomasterfrom
frollapply_n_lenx
Open

Fix frollapply to handle n > len case#7650
jangorecki wants to merge 4 commits intomasterfrom
frollapply_n_lenx

Conversation

@jangorecki
Copy link
Member

@jangorecki jangorecki commented Feb 26, 2026

closes #7646

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (67e7840) to head (301409b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7650   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          87       87           
  Lines       16897    16900    +3     
=======================================
+ Hits        16733    16736    +3     
  Misses        164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Feb 26, 2026

  • HEAD=frollapply_n_lenx stopped early for fread(select=list(Date='date')) improved in #6107
    Comparison Plot

Generated via commit 301409b

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 38 seconds
Installing different package versions 21 seconds
Running and plotting the test cases 3 minutes and 29 seconds

Copy link
Member

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it warrant a patch release?

Co-authored-by: Michael Chirico <chiricom@google.com>
@jangorecki
Copy link
Member Author

No, function is said to be experimental so I think we can postpone 1.18.4 till CRAN will require us to patch something. Then this change should be included. Unless there will be many reports about it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

frollapply can produce output longer than the input when the window-length is also longer than the input

2 participants