custom data.frame classes redirected to as.data.frame before as.data.table#5700
Merged
MichaelChirico merged 8 commits intomasterfrom Jan 17, 2025
Merged
custom data.frame classes redirected to as.data.frame before as.data.table#5700MichaelChirico merged 8 commits intomasterfrom
MichaelChirico merged 8 commits intomasterfrom
Conversation
jangorecki
commented
Dec 9, 2023
Member
|
Hi @jangorecki would you mind summarizing what needs to be done to get this ready for review? That way someone else could have a go at sewing it up if you don't get to it first. Thanks! |
Member
Author
|
Examine why test fails, if still fails. |
MichaelChirico
approved these changes
Dec 4, 2024
Member
MichaelChirico
left a comment
MichaelChirico
left a comment
There was a problem hiding this comment.
I am OK to merge with Jan's ack (and a NEWS entry).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5700 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 79 79
Lines 14630 14631 +1
=======================================
+ Hits 14429 14430 +1
Misses 201 201 ☔ View full report in Codecov by Sentry. |
|
Generated via commit 9633663 Download link for the artifact containing the test results: ↓ atime-results.zip
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5699