Switch from color_cycle to prop_cycle in tomography plotting tools#150
Switch from color_cycle to prop_cycle in tomography plotting tools#150
color_cycle to prop_cycle in tomography plotting tools#150Conversation
this was a name change in matplotlib 1.5, and the old name is now deprecated
|
This matplotlib>=1.5 requirement should be listed somewhere in the project. A good place might be under optional requirements in |
|
Hmm, it's not actually a requirement; it's imported in try blocks. Maybe we should check the version inside the try block and raise if < 1.5. |
1 similar comment
|
Right, but matplotlib is an optional requirement and can be listed as such. I also imagine it should be listed in the docs somewhere. Actually, checking just now the matplotlib website, 2.2.x is the LTS dual py2/3 release. It appears that 1.5 was the last 1.x release, which is no longer supported. I'd probably still put a check in somewhere, but you might not need to put it in the docs. |
|
I checked travis, its reporting failures on doctest for both 2.7 and 3.5 3.5: 2.7: |
|
I tried this, but the cycler can't be indexed Maybe something like |
This was a name change in matplotlib 1.5 of the default color cycle, and the old name is now deprecated.
This PR addresses QInfer/qinfer-examples#4 (comment)