Skip to content

Conversation

@cgoldberg
Copy link
Contributor

This PR fixes the way Iterable is imported. With this change, it will import it from collections.abc rather than collections (which emitted a deprecation warning).

Explanation:
Importing abstract base classes from collections instead of from collections.abc was deprecated starting in Python 3.3+, and in 3.8 it will stop working. The "Astract Base Classes for Collections" module (collections.abc) was introduced in Python 3.3. In previous Python versions, the ABC's were part of the collections module.

Note:
The deprecation warning was not displayed when running tests with tox because nosetests was swallowing the message.

@codecov-io
Copy link

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   80.81%   80.81%           
=======================================
  Files          23       23           
  Lines        3941     3941           
  Branches      458      458           
=======================================
  Hits         3185     3185           
  Misses        680      680           
  Partials       76       76
Impacted Files Coverage Δ
pywt/_utils.py 76.92% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6116b29...f4ea04d. Read the comment docs.

@rgommers rgommers merged commit 1c1d83f into PyWavelets:master Nov 24, 2018
@rgommers
Copy link
Member

Merged, thanks @cgoldberg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants