Fix deprecated import for Iterable #436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the way
Iterableis imported. With this change, it will import it fromcollections.abcrather thancollections(which emitted a deprecation warning).Explanation:
Importing abstract base classes from
collectionsinstead of fromcollections.abcwas deprecated starting in Python 3.3+, and in 3.8 it will stop working. The "Astract Base Classes for Collections" module (collections.abc) was introduced in Python 3.3. In previous Python versions, the ABC's were part of thecollectionsmodule.Note:
The deprecation warning was not displayed when running tests with
toxbecausenosetestswas swallowing the message.