Update release.yml to support commit signing#458
Conversation
The `planetscale/ghcommit-action` action uses ghcommit which uses the GitHub API, which supports commit signing by default. This removes the need to configure a GPG key in our Action.
| - name: Commit release changes | ||
| id: commit-release | ||
| uses: planetscale/ghcommit-action@25309d8005ac7c3bcd61d3fe19b69e0fe47dbdde # v0.2.20 | ||
| with: | ||
| commit_message: "chore: Release v${{ steps.sampo-release.outputs.new_version }}" | ||
| repo: ${{ github.repository }} | ||
| branch: master | ||
| env: | ||
| GITHUB_TOKEN: ${{ steps.releaser.outputs.token }} |
There was a problem hiding this comment.
What user.name and user.email is it going to use? 🤔
There was a problem hiding this comment.
The GitHub API will use the identity associated with the GITHUB_TOKEN. In this case that would be the "Releaser (posthog-python)" GitHub App.
There was a problem hiding this comment.
That's pretty good! Better than what we had before. I wonder what image it's going to use 🤔
There was a problem hiding this comment.
It should be the image we've set for the GitHub App. But only one way to find out!
There was a problem hiding this comment.
I love how safe this all sounds :)
In Portuguese, Security and Safety are the exact same word - it took me some time to understand the difference between them in English -, so I hope you can appreciate why this is funny in my head
There was a problem hiding this comment.
In Portuguese, Security and Safety are the exact same word
I love this so much
|
Last reviewed commit: 18a2943 |
posthog-python Compliance ReportDate: 2026-03-10 02:48:44 UTC ✅ All Tests Passed!29/29 tests passed Capture Tests✅ 29/29 tests passed View Details
|
| - name: Commit release changes | ||
| id: commit-release | ||
| uses: planetscale/ghcommit-action@25309d8005ac7c3bcd61d3fe19b69e0fe47dbdde # v0.2.20 | ||
| with: | ||
| commit_message: "chore: Release v${{ steps.sampo-release.outputs.new_version }}" | ||
| repo: ${{ github.repository }} | ||
| branch: master | ||
| env: | ||
| GITHUB_TOKEN: ${{ steps.releaser.outputs.token }} |
There was a problem hiding this comment.
That's pretty good! Better than what we had before. I wonder what image it's going to use 🤔
2 participants
The
planetscale/ghcommit-actionaction uses ghcommit which uses the GitHub API, which supports commit signing by default. This removes the need to configure a GPG key in our Action.I have not tested this and I think it would be tricky to test. It seems reasonable to merge, attempt a release, and roll back if it breaks.