Open
Conversation
jeltz
requested changes
Feb 19, 2026
Collaborator
jeltz
left a comment
jeltz
left a comment
There was a problem hiding this comment.
Looks good other than my small comment.
| state->area_handle = DSA_HANDLE_INVALID; | ||
| }; | ||
|
|
||
| bool found = false; |
Collaborator
There was a problem hiding this comment.
Why is it initialized to false? PostgreSQL's code does not do that.
Collaborator
Author
There was a problem hiding this comment.
Mainly to prevent a warning about a possibly uninitialized variable.
Also that warning kind of makes sense, since GetNamedDSMSegment is an external dependency, and we can't see into it from here.
jeltz
approved these changes
Feb 20, 2026
This adds an ifdef around the changes PG19 GetNamedDSMSegment function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an ifdef around the changes PG19 GetNamedDSMSegment function
We still don't have CI for it, but I built too many times locally againts PG19 to keep this commit local.