Fix: examples/large-app#104
Merged
SekibOmazic merged 2 commits intoPatrickJS:masterfrom Oct 28, 2015
dotcs:fix-large-app
Merged
Fix: examples/large-app#104SekibOmazic merged 2 commits intoPatrickJS:masterfrom dotcs:fix-large-app
SekibOmazic merged 2 commits intoPatrickJS:masterfrom
dotcs:fix-large-app
Conversation
Contributor
Author
|
I forgot to mention that I have disabled the 'draggable_div' example because I could not find out how to include it properly. To me it seems as this component has been abandoned. Any help on how to include this component is appreciated. |
Contributor
Author
|
Update: I have fixed the 'search github' example in PR #107. |
Contributor
Contributor
Author
|
@SekibOmazic Done. The I have enabled the rxjs examples again. With the fixes in #107 all rxjs examples are working fine again. Please give it a try. |
Contributor
|
LGTM |
Contributor
|
@dotcs Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have fixed several issues with angular2@2.0.0-alpha.44. Furthermore I have fixed a broken import (see a493839#commitcomment-13901195).
I also changed an import statement to keep the syntax the same across the application, because webpack complained about the import:
There are still some issues with the 'search github' and 'todo' components, but the router does work again and at least webpack compiles without an error. This PR fixes #92.