Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #331 +/- ##
===========================================
- Coverage 74.36% 74.24% -0.13%
===========================================
Files 53 53
Lines 5138 5168 +30
Branches 903 910 +7
===========================================
+ Hits 3821 3837 +16
- Misses 977 984 +7
- Partials 340 347 +7 ☔ View full report in Codecov by Sentry. |
dweindl
force-pushed
the
ant
branch
2 times, most recently
from
0839523 to
af542d9
Compare
dilpath
approved these changes
Dec 9, 2024
Member
dilpath
left a comment
dilpath
left a comment
There was a problem hiding this comment.
Nice, add support for antimony to the docs and spec in v2?
Comment on lines
361
to
370
| model = SbmlModel.from_antimony( | ||
| "fixedParameter1 = 0.5\n" | ||
| "fixedParameter2 = 1.0\n" | ||
| "dynamicParameter1 = 0.0\n" | ||
| "observableParameter1_obs1 = 0.0\n" | ||
| "observableParameter2_obs1 = 0.0\n" | ||
| "observableParameter1_obs2 = 0.0" | ||
| ) |
Member
There was a problem hiding this comment.
Use """ instead of \n? Or does antimony interpret indentation?
Member
Author
There was a problem hiding this comment.
Makes sense. No, it doesn't.
Member
Author
Undecided. Convenient, but not really a strong enough reason to deviate from SBML and make things less portable. |
Simplify creating a PEtab SbmlModel from antimony files or strings. Replace simplesbml by antimony in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify creating a PEtab SbmlModel from antimony files / strings.
Replace simplesbml by antimony in tests.