Remove initializationPrior and rename objectivePrior#612
Merged
dweindl merged 6 commits intoPEtab-dev:mainfrom Mar 26, 2025
Merged
Remove initializationPrior and rename objectivePrior#612dweindl merged 6 commits intoPEtab-dev:mainfrom
initializationPrior and rename objectivePrior#612dweindl merged 6 commits intoPEtab-dev:mainfrom
Conversation
dweindl
reviewed
Mar 25, 2025
matthiaskoenig
approved these changes
Mar 25, 2025
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
dweindl
reviewed
Mar 25, 2025
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
FFroehlich
approved these changes
Mar 25, 2025
Member
|
Please add a brief summary to the "Changes" section. Something like:
|
Contributor
Author
Thanks for noticing. I have now added a short summary in the changes section. If it looks good, feel free to merge, then I will update #595 |
fbergmann
approved these changes
Mar 26, 2025
Member
Go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the discussions at the editor meetings, this PR removes
initializationPriorfrom the parameter table, and renamesobjectivePriorTypetoprior.