Merged
Conversation
current issues: - not errorbar redoing - not clear how barplots would be plotted - highlighting with multiple observables in one plot seems difficult.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for grouping data in plots by adding a new group_by parameter and updating how grouping is handled across the plotting components and toolbar options.
- Added a group_by argument to PlotWorker and updated the corresponding call sites.
- Introduced ToolbarOptionManager to synchronize grouping options across toolbars and updated the UI accordingly.
- Adjusted the plot point click callback to handle an additional data_type parameter for proper proxy resolution.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/petab_gui/views/simple_plot_view.py | Added group_by support for plot worker and updated legend handling and toolbar options. |
| src/petab_gui/controllers/mother_controller.py | Updated the click callback to use the new signature and resolve the correct proxy based on data_type. |
Comment on lines
+374
to
+378
| self.groupy_by_options = { | ||
| grp: QAction(f"Groupy by {grp}", self) | ||
| for grp in ["observable", "dataset", "condition"] | ||
| } | ||
| for grp, action in self.groupy_by_options.items(): |
There was a problem hiding this comment.
The UI label text 'Groupy by' appears to be a typo. Consider changing it to 'Group by' for clarity.
Suggested change
| self.groupy_by_options = { | |
| grp: QAction(f"Groupy by {grp}", self) | |
| for grp in ["observable", "dataset", "condition"] | |
| } | |
| for grp, action in self.groupy_by_options.items(): | |
| self.group_by_options = { | |
| grp: QAction(f"Group by {grp}", self) | |
| for grp in ["observable", "dataset", "condition"] | |
| } | |
| for grp, action in self.group_by_options.items(): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Options to plot by. (not yet vis spec)