Merged
Conversation
# Conflicts: # src/petab_gui/controllers/mother_controller.py # src/petab_gui/models/pandas_table_model.py # src/petab_gui/views/task_bar.py
1. Copy pasting is one big undo/redo 2. Setting an invalid index has a new overwrite message and sets a default value 3. Ordering of functionality is changes such that a row is only checked when necessary 4. In parameter case, now accounts for potentially more parameters than were thrown into the model
Closed
fbergmann
reviewed
Apr 23, 2025
fbergmann
requested changes
Apr 23, 2025
Collaborator
fbergmann
left a comment
fbergmann
left a comment
There was a problem hiding this comment.
works great for me, can you look whether to apply the tiny changes for the order of the menu items.
also when i select a range and just hit the delete key, i would want the entries deleted (assigned NaN). Similarly to how when i select a range of cells and i enter 2, then all of them get the value 2.
Collaborator
Author
|
Will adjust the Multidelete in the PR that also tackles display of multichange 👍🏼 |
Collaborator
Author
|
Gonna merge it for now, can push other requested changes in another PR 👍🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the whole Do/Undo schema. Additionally fixes: