Skip to content

migrate to vite and vitest#240

Merged
jamesrweb merged 4 commits intomasterfrom
migrate-organisation
Apr 20, 2023
Merged

migrate to vite and vitest#240
jamesrweb merged 4 commits intomasterfrom
migrate-organisation

Conversation

@jamesrweb
Copy link
Member

@jamesrweb jamesrweb commented Apr 19, 2023 •
edited
Loading

⚠️ Warning: Do not merge. Please review thoroughly but do not merge.

Before merging, some configurations on NPM need altered but these will not be done until after this PR is approved for merging but before it is actually merged as part of deployment preparations.

Fixes #238
Fixes #239

Proposed Changes

  • Migrate builds to Vite
  • Migrate tests to Vitest
  • Move to the @P5-wrapper npm org namespace

Additional Notes (optional)

This will deprecate the react-p5-wrapper dependency name, before merging the changes should be announced with a clear timeline. All functionality currently supported including the demo app should be supported or migrated before merging this also.

@jamesrweb jamesrweb added dependencies Pull requests that update a dependency file documentation Pull requests that update project documentation labels Apr 19, 2023
@jamesrweb jamesrweb self-assigned this Apr 19, 2023
@jamesrweb jamesrweb force-pushed the migrate-organisation branch 4 times, most recently from ae2b651 to a47df39 Compare April 19, 2023 18:26
@jamesrweb jamesrweb force-pushed the migrate-organisation branch from a47df39 to a1f6fc1 Compare April 19, 2023 18:27
@jamesrweb jamesrweb marked this pull request as ready for review April 19, 2023 19:46
@jamesrweb jamesrweb requested a review from yevdyko April 19, 2023 19:46
yevdyko
yevdyko approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@yevdyko yevdyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea! I didn't check it locally, but the code looks good. You might want to add a new blank line at the end of the files where it was missing

@jamesrweb jamesrweb merged commit 286c0a8 into master Apr 20, 2023
@jamesrweb jamesrweb deleted the migrate-organisation branch April 20, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yevdyko yevdyko yevdyko approved these changes

Assignees

@jamesrweb jamesrweb

Labels

dependencies Pull requests that update a dependency file documentation Pull requests that update project documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate to the @P5-wrapper npm org Migrate to Vite and Vitest

2 participants

@jamesrweb @yevdyko