v2.28.0 by nxglabs · Pull Request #1941 · OpenSignLabs/OpenSign

nxglabs · 2025-09-15T14:51:20Z

No description provided.

Merge pull request #1291 from nxglabs/staging

vercel · 2025-09-15T14:51:22Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
open-sign	Ready	Preview	Comment	Sep 15, 2025 2:52pm

apps/OpenSignServer/cloud/customRoute/deleteAccount/deleteUserGet.js

Copilot

Pull Request Overview

This appears to be a synchronization merge from a staging branch to the main branch, updating dependencies and implementing various enhancements across the OpenSign application. The changes include package updates, new OTP-based user account deletion functionality, UI improvements, and code refactoring.

Package dependency updates across both server and client applications
Implementation of OTP-based account deletion system replacing password-based deletion
Addition of "Sent Date" column to document reports and various UI enhancements

Reviewed Changes

Copilot reviewed 44 out of 45 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
apps/OpenSignServer/package.json	Updates AWS SDK, dotenv, posthog-node, and other dependencies to newer versions
apps/OpenSignServer/cloud/parsefunction/reportsJson.js	Adds DocSentAt field to inProgressKeys array for report data
apps/OpenSignServer/cloud/parsefunction/pdf/PDF.js	Refactors HTTP requests using shared headers and adds new processPdf function
apps/OpenSignServer/cloud/customRoute/deleteAccount/*.js	Implements new OTP-based user deletion system with utilities, handlers, and UI
apps/OpenSign/src/reports//*.jsx	Adds isSubmit state management and loading indicators to prevent duplicate submissions
apps/OpenSign/src/redux/reducers/widgetSlice.js	Adds typedSignFont state management for signature font preferences
apps/OpenSign/src/primitives/RenderReportCell.jsx	Adds "Sent Date" column rendering support
apps/OpenSign/src/components/pdf/WidgetsValueModal.jsx	Updates font handling to use Redux state for typed signatures
apps/OpenSign/src/components/pdf/PrefillWidgetsModal.jsx	Adds submit state handling and removes label hiding logic
apps/OpenSign/package.json	Updates serve dependency to latest version
apps/OpenSign/public/locales/*/translation.json	Adds new translation keys for UI enhancements

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-15T14:53:48Z

apps/OpenSignServer/cloud/parsefunction/pdf/PDF.js

+ * @param {Object} _resDoc - Document details (expects AuditTrail, etc.)
+ * @param {Buffer|Uint8Array} pdfBytes - Original PDF bytes
+ * @param {string} [options.reason] - Reason text used in placeholder
+ * @param {string} [options.UserPtr] -  user pointer (for audit trail)
+ * @param {string} [options.ipAddress] - IP (for audit trail)
+ * @param {string} [options.Signature] - Signature (for audit trail)
+ * @returns {Promise<Buffer>} merged PDF Buffer
+ */
+async function processPdf(_resDoc, PdfBuffer, reason) {


The processPdf function is missing proper JSDoc documentation for the _resDoc parameter, which appears to be unused in the function body. Either document its purpose or remove it if not needed.

Suggested change

* @param {Object} _resDoc - Document details (expects AuditTrail, etc.)

* @param {Buffer|Uint8Array} pdfBytes - Original PDF bytes

* @param {string} [options.reason] - Reason text used in placeholder

* @param {string} [options.UserPtr] - user pointer (for audit trail)

* @param {string} [options.ipAddress] - IP (for audit trail)

* @param {string} [options.Signature] - Signature (for audit trail)

* @returns {Promise<Buffer>} merged PDF Buffer

*/

async function processPdf(_resDoc, PdfBuffer, reason) {

* @param {Buffer|Uint8Array} PdfBuffer - Original PDF bytes

* @param {string} reason - Reason text used in placeholder

* @returns {Promise<Buffer>} merged PDF Buffer

*/

async function processPdf(PdfBuffer, reason) {

Copilot · 2025-09-15T14:53:49Z

apps/OpenSignServer/cloud/customRoute/deleteAccount/deleteUtils.js

+export function generateOtp(len = OTP_LENGTH) {
+  // 6-digit numeric OTP (000000–999999, padded)
+  const n = Math.floor(Math.random() * Math.pow(10, len));
+  return String(n).padStart(len, '0');
+}


The OTP generation uses Math.random() which is not cryptographically secure. Consider using crypto.randomInt() or a cryptographically secure random number generator for better security.

Copilot · 2025-09-15T14:53:49Z

apps/OpenSignServer/cloud/customRoute/deleteAccount/deleteUserOtp.js

+    await extUser.save(null, { useMasterKey: true });
+    return res.json({ ok: true, cooldownSec: RESEND_COOLDOWN_SEC, expiresInMin: OTP_EXPIRES_MIN });
+  } catch (err) {
+    console.log('Error sending delete OTP (POST /otp):', err?.response?.data || err);


Logging the full error response may expose sensitive information. Consider logging only a sanitized error message or error code.

Suggested change

console.log('Error sending delete OTP (POST /otp):', err?.response?.data || err);

console.log('Error sending delete OTP (POST /otp):', err?.message || 'Unknown error', err?.response?.status ? `Status: ${err.response.status}` : '');

Copilot · 2025-09-15T14:53:49Z

apps/OpenSign/src/reports/document/DocumentsReport.jsx

+        if (
+          isCompleted
+        ) {


[nitpick] The condition formatting is inconsistent and unnecessarily split across multiple lines for a simple boolean check. Should be: if (isCompleted) {

Suggested change

if (

isCompleted

) {

if (isCompleted) {

Copilot · 2025-09-15T14:53:50Z

apps/OpenSign/src/components/pdf/PrefillWidgetsModal.jsx

+                  <label
+                    htmlFor={`checkbox-${position.key + ind}`}
+                    className="text-xs mb-0 text-center ml-[3px] cursor-pointer"
+                  >
+                    {data}
+                  </label>


The removal of the isHideLabel condition check means labels will always be shown now. If this is intentional, consider adding a comment explaining why this logic was simplified.

Copilot · 2025-09-15T14:53:50Z

apps/OpenSign/src/components/pdf/WidgetsValueModal.jsx

+        const selectedFont = typedSignFont || fontSelect;
+        await document.fonts.load(`20px ${selectedFont}`);


The font loading error handling should provide more specific error information. Consider catching and logging the specific font name that failed to load.

Copilot · 2025-09-15T14:53:50Z

apps/OpenSign/src/json/dashboardJson.js

            class: "contracts_Document",
            query:
-              'where={"Type":null,"Signers":{"#*exists":true},"Placeholders":{"#*exists":true},"SignedUrl":{"#*exists":true},"IsCompleted":false,"IsDeclined":false,"IsArchive":null,"CreatedBy":{"__type":"Pointer","className":"_User","objectId":"#UserId.objectId#"},"ExpiryDate":{"#*gt":{"__type":"#Date#","iso":"#today#"}}}&keys=Name,ExpiryDate,SignedUrl,Signers&count=1',
+              'where={"Type":{"#*ne":"Folder"},"Signers":{"#*exists":true},"Placeholders":{"#*exists":true},"SignedUrl":{"#*exists":true},"IsCompleted":{"#*ne":true},"IsDeclined":{"#*ne":true},"IsArchive":{"#*ne":true},"CreatedBy":{"__type":"Pointer","className":"_User","objectId":"#UserId.objectId#"},"ExpiryDate":{"#*gt":{"__type":"#Date#","iso":"#today#"}}}&count=1&limit=0',


[nitpick] This query string is extremely long and hard to read. Consider breaking it into multiple lines or using a query builder pattern for better maintainability.

Suggested change

'where={"Type":{"#*ne":"Folder"},"Signers":{"#*exists":true},"Placeholders":{"#*exists":true},"SignedUrl":{"#*exists":true},"IsCompleted":{"#*ne":true},"IsDeclined":{"#*ne":true},"IsArchive":{"#*ne":true},"CreatedBy":{"__type":"Pointer","className":"_User","objectId":"#UserId.objectId#"},"ExpiryDate":{"#*gt":{"__type":"#Date#","iso":"#today#"}}}&count=1&limit=0',

`where={

"Type":{"#*ne":"Folder"},

"Signers":{"#*exists":true},

"Placeholders":{"#*exists":true},

"SignedUrl":{"#*exists":true},

"IsCompleted":{"#*ne":true},

"IsDeclined":{"#*ne":true},

"IsArchive":{"#*ne":true},

"CreatedBy":{"__type":"Pointer","className":"_User","objectId":"#UserId.objectId#"},

"ExpiryDate":{"#*gt":{"__type":"#Date#","iso":"#today#"}}

}&count=1&limit=0`,

Merge pull request #1292 from nxglabs/sync-to-public_repo-17730712175

ca4ccfd

Merge pull request #1291 from nxglabs/staging

Copilot AI review requested due to automatic review settings September 15, 2025 14:51

prafull-opensignlabs changed the title ~~Merge pull request #1292 from nxglabs/sync-to-public_repo-17730712175~~ v2.28.0 Sep 15, 2025

vercel bot deployed to Preview – open-sign September 15, 2025 14:52 View deployment

github-advanced-security bot found potential problems Sep 15, 2025

View reviewed changes

apps/OpenSignServer/cloud/customRoute/deleteAccount/deleteUserGet.js Dismissed Show dismissed Hide dismissed

prafull-opensignlabs approved these changes Sep 15, 2025

View reviewed changes

prafull-opensignlabs merged commit fe21978 into staging Sep 15, 2025
4 of 5 checks passed

Copilot AI reviewed Sep 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v2.28.0#1941

v2.28.0#1941
prafull-opensignlabs merged 1 commit intostagingfrom
updates-17737216200

nxglabs commented Sep 15, 2025 •

edited by prafull-opensignlabs

Loading

Uh oh!

vercel bot commented Sep 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 15, 2025

Uh oh!

Copilot AI Sep 15, 2025

Uh oh!

Copilot AI Sep 15, 2025

Uh oh!

Copilot AI Sep 15, 2025

Uh oh!

Copilot AI Sep 15, 2025

Uh oh!

Copilot AI Sep 15, 2025

Uh oh!

Copilot AI Sep 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	console.log('Error sending delete OTP (POST /otp):', err?.response?.data \|\| err);
	console.log('Error sending delete OTP (POST /otp):', err?.message \|\| 'Unknown error', err?.response?.status ? `Status: ${err.response.status}` : '');

		const selectedFont = typedSignFont \|\| fontSelect;
		await document.fonts.load(`20px ${selectedFont}`);

Conversation

nxglabs commented Sep 15, 2025 • edited by prafull-opensignlabs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nxglabs commented Sep 15, 2025 •

edited by prafull-opensignlabs

Loading

vercel bot commented Sep 15, 2025 •

edited

Loading