Conversation
Merge pull request
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
prafull-opensignlabs
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This PR implements a comprehensive contact management system for OpenSign along with various improvements to the UI and codebase structure. The primary focus is adding support for importing, managing, and organizing contacts within the application.
Key changes:
- Contact Management System: Adds complete CRUD operations for contacts with import/export capabilities, additional fields (Company, JobTitle), and enhanced contact forms
- Redux State Refactoring: Replaces showHeader reducer with sidebarReducer and adds new widget state management for prefill functionality
- UI/UX Enhancements: Improves modals, user deletion workflows, session management, and PDF verification features
Reviewed Changes
Copilot reviewed 109 out of 176 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| DocumentsReport.jsx | New comprehensive document reporting component with advanced filtering and actions |
| ImportContact.jsx | Contact import functionality supporting CSV/Excel with validation |
| EditContactForm.jsx | Enhanced contact editing with additional fields (Company, JobTitle) |
| Contactbook.jsx | Main contact management interface with search, pagination, and CRUD operations |
| store.js | Updated Redux store configuration replacing showHeader with sidebarReducer |
| widgetSlice.js | Enhanced widget state management with prefill image handling |
| sidebarReducer.js | New sidebar state management replacing showHeader functionality |
| Multiple primitives | Various UI component improvements including modals, validation, and user management |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if (file) { | ||
| const fileName = file.name; | ||
| const fileNameExt = fileName | ||
| .substr(fileName.lastIndexOf(".") + 1) |
There was a problem hiding this comment.
Use substring() or slice() instead of the deprecated substr() method. Replace with fileName.substring(fileName.lastIndexOf('.') + 1).toLowerCase()
| .substr(fileName.lastIndexOf(".") + 1) | |
| .substring(fileName.lastIndexOf(".") + 1) |
| const { t } = useTranslation(); | ||
| const [isCheck, setIsCheck] = useState(false); | ||
| const [isCheck, setIsCheck] = useState(true); |
There was a problem hiding this comment.
The initial state should be false to match the original behavior. Setting it to true by default will change the existing functionality.
| const [isCheck, setIsCheck] = useState(true); | |
| const [isCheck, setIsCheck] = useState(false); |
| id="phone" | ||
| value={phone} | ||
| onChange={(e) => setPhone(e.target.value)} | ||
| // disabled={addYourself} |
There was a problem hiding this comment.
Remove commented-out code or provide a clear explanation for why it's preserved. Commented code should be cleaned up before merging.
| if (!Number.isFinite(num)) { | ||
| // Checks for NaN, Infinity, -Infinity |
There was a problem hiding this comment.
[nitpick] Consider using Number.isSafeInteger(num) for stricter validation of PDF byte range values, as PDF specifications typically expect safe integer values.
| if (!Number.isFinite(num)) { | |
| // Checks for NaN, Infinity, -Infinity | |
| if (!Number.isSafeInteger(num)) { | |
| // Checks for NaN, Infinity, -Infinity, and non-integer or unsafe integer values |
| let UserProfile = | ||
| localStorage.getItem("UserInformation") && | ||
| JSON.parse(localStorage.getItem("UserInformation")); |
There was a problem hiding this comment.
Avoid calling localStorage.getItem('UserInformation') twice. Store the result in a variable first: const userInfo = localStorage.getItem('UserInformation'); let UserProfile = userInfo && JSON.parse(userInfo);
| let UserProfile = | |
| localStorage.getItem("UserInformation") && | |
| JSON.parse(localStorage.getItem("UserInformation")); | |
| const userInfo = localStorage.getItem("UserInformation"); | |
| let UserProfile = userInfo && JSON.parse(userInfo); |
| await onConfirm(); | ||
| } catch (err) { | ||
| console.log("err ", err); | ||
| setError(err?.message || t("something-went-wron-mssg")); |
There was a problem hiding this comment.
Fix typo in translation key: 'something-went-wron-mssg' should be 'something-went-wrong-mssg'
| setError(err?.message || t("something-went-wron-mssg")); | |
| setError(err?.message || t("something-went-wrong-mssg")); |
Merge pull request