fix: managesign report alignment and loader issue#1889
Merged
prafull-opensignlabs merged 1 commit intostagingfrom Aug 6, 2025
Merged
fix: managesign report alignment and loader issue#1889prafull-opensignlabs merged 1 commit intostagingfrom
prafull-opensignlabs merged 1 commit intostagingfrom
Conversation
fix: managesign report alignment and loader issue
There was a problem hiding this comment.
Pull Request Overview
This PR fixes alignment and loader issues in the ManageSign report by standardizing signature canvas dimensions and removing redundant loader implementation.
- Introduces a new
.mysignatureCanvasCSS class with consistent dimensions across different screen sizes - Removes the loader overlay from the signature canvas area in ManageSign component
- Updates signature canvas to use the new CSS class instead of inline width/height properties
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/OpenSign/src/styles/signature.css | Adds new .mysignatureCanvas class with responsive dimensions and dark theme support |
| apps/OpenSign/src/pages/Managesign.jsx | Updates signature canvas to use new CSS class and removes loader overlay |
| )} | ||
| {image ? ( | ||
| <div className="signatureCanvas relative border-[2px] border-[#888] rounded-box overflow-hidden"> | ||
| <div className="mysignatureCanvas relative border-[2px] border-[#888] rounded-box overflow-hidden"> |
There was a problem hiding this comment.
There are two spaces between 'mysignatureCanvas' and 'relative' in the className. This should be a single space for consistency.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
prafull-opensignlabs
changed the title
prafull-opensignlabs
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: managesign report alignment and loader issue