feat: allow preferences menu for all user #1880
Merged
prafull-opensignlabs merged 1 commit intostagingfrom Aug 1, 2025
Merged
Conversation
feat: allow preferences menu for all user and add smtp setting in it
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
prafull-opensignlabs
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR allows preferences menu access for all users and adds SMTP settings functionality, expanding the sidebar permissions and improving internationalization.
- Allow all users to access preferences menu instead of restricting to admin/org admin roles
- Add SMTP configuration options in preferences with translations for multiple languages
- Update sidebar logic to simplify user role handling and menu item display
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| apps/OpenSign/src/pages/Preferences.jsx | Updates alert message to use translation and fixes spelling in console logs |
| apps/OpenSign/src/components/sidebar/Sidebar.jsx | Simplifies role-based menu logic to allow all users access to preferences |
| apps/OpenSign/public/locales/*/translation.json | Adds comprehensive SMTP-related translations across multiple languages |
| } | ||
| } catch (err) { | ||
| console.log("Err in resetting request mail", err); | ||
| console.log("Err in reseting request mail", err); |
There was a problem hiding this comment.
The word 'reseting' should be spelled 'resetting' with double 't'.
Suggested change
| console.log("Err in reseting request mail", err); | |
| console.log("Err in resetting request mail", err); |
| } | ||
| } catch (err) { | ||
| console.log("Err in resetting completion mail", err); | ||
| console.log("Err in reseting completion mail", err); |
There was a problem hiding this comment.
The word 'reseting' should be spelled 'resetting' with double 't'.
| "show-more": "Mostrar más", | ||
| "browse-or-drag-to-replace-existing-file": "Busque o arrastre y suelte un nuevo archivo para reemplazar el existente", | ||
| "optional-details": "Detalles opcionales", | ||
| "mail-adapter-subscription-alert": "Bitte upgraden Sie auf den Professional- oder Team-Plan, um ein benutzerdefiniertes SMTP einzurichten.", |
There was a problem hiding this comment.
This translation is in German but should be in Spanish. The correct Spanish translation should be something like 'Por favor, actualice al plan Profesional o de Equipo para configurar un SMTP personalizado.'
| "sender-email": "Sender Email", | ||
| "username": "Username", | ||
| "use-default-mail-adapter": "Are you sure you want to use {{appName}}'s default mail servers to send your signature request emails? We recommend using your own Gmail or SMTP servers for improved inbox deliverability.", | ||
| "verification-code-sent-registered-email": "A verification code has been sent to your registered email <1>{{useremail}}</1> confirm your settings. Please enter the code below.", |
There was a problem hiding this comment.
Missing 'to' between '{{useremail}}' and 'confirm'. Should read '...email <1>{{useremail}}</1> to confirm your settings.'
Suggested change
| "verification-code-sent-registered-email": "A verification code has been sent to your registered email <1>{{useremail}}</1> confirm your settings. Please enter the code below.", | |
| "verification-code-sent-registered-email": "A verification code has been sent to your registered email <1>{{useremail}}</1> to confirm your settings. Please enter the code below.", |
prafull-opensignlabs
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: allow preferences menu for all user