refactor: correct grammar and normalise font size of signer email in report#1868
Merged
prafull-opensignlabs merged 1 commit intostagingfrom Jul 30, 2025
Merged
refactor: correct grammar and normalise font size of signer email in report#1868prafull-opensignlabs merged 1 commit intostagingfrom
prafull-opensignlabs merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR includes UI improvements, localization enhancements, and spelling corrections to improve the user experience in the OpenSign application. The changes focus on improving the signers display, fixing grammatical errors, and adding internationalization support.
- Enhanced signers display layout and spacing in the report table
- Fixed spelling errors in console log messages and corrected grammatical issues in translation strings
- Added localization support for file replacement text across multiple languages
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| GetReportDisplay.jsx | Updated signers display styling with improved spacing and removed font styling |
| Preferences.jsx | Fixed spelling errors in console log messages |
| EditTemplate.jsx | Replaced hardcoded text with internationalized translation key |
| translation.json (multiple languages) | Added new translation keys and corrected grammatical errors in existing translations |
| }) | ||
| } | ||
| className="ml-2 text-xs font-medium text-blue-500 underline focus:outline-none" | ||
| className="ml-2 mt-1 text-xs font-medium text-blue-500 underline focus:outline-none" |
There was a problem hiding this comment.
The line has inconsistent indentation with extra leading spaces compared to the surrounding code.
| "placeholder-alert-4": "You have successfully sent mails to all recipients!", | ||
| "placeholder-mail-alert": "You have successfully sent email to {{name}}. Subsequent signers will get email(s) once {{name}} signs the document", | ||
| "placeholder-mail-alert-you": "Subsequent signers will get email(s) once you signs the document.", | ||
| "placeholder-mail-alert-you": "Subsequent signers will get email(s) once you sign the document.", |
There was a problem hiding this comment.
Fixed grammar error from 'once you signs' to 'once you sign' - this is a correct improvement.
prafull-opensignlabs
changed the title
prafull-opensignlabs
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.