Skip to content

dark-theme logo #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prafull-opensignlabs merged 1 commit into from
Jul 7, 2025
Merged

dark-theme logo #1838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions apps/OpenSign/src/components/Header.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ const Header = ({ showSidebar, setIsMenu, isConsole }) => {
const image = localStorage.getItem("profileImg") || dp;
const [isOpen, setIsOpen] = useState(false);
const [applogo, setAppLogo] = useState("");
const [isDarkTheme, setIsDarkTheme] = useState();
Copy link

Copilot AI Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initialize isDarkTheme with a default boolean (e.g., useState(false)) to avoid an undefined state on first render.

Suggested change
const [isDarkTheme, setIsDarkTheme] = useState();
const [isDarkTheme, setIsDarkTheme] = useState(false);

Copilot uses AI. Check for mistakes.

const toggleDropdown = () => {
setIsOpen(!isOpen);
Expand Down Expand Up @@ -88,22 +89,15 @@ const Header = ({ showSidebar, setIsMenu, isConsole }) => {


useEffect(() => {
const updateLogoForTheme = () => {
const isDarkMode =
const updateThemeStatus = () => {
const isDarkTheme =
document.documentElement.getAttribute("data-theme") === "opensigndark";
const logo = isDarkMode
? "/static/js/assets/images/logo-dark.png" // Path to the dark mode logo
: appInfo.applogo; // Use current logo for light mode
if (applogo !== logo) {
setAppLogo(logo);
}
setIsDarkTheme(isDarkTheme);
};

// Set the logo immediately based on the current theme
updateLogoForTheme();
updateThemeStatus();

const observer = new MutationObserver(() => {
updateLogoForTheme();
updateThemeStatus();
});

observer.observe(document.documentElement, {
Expand All @@ -112,7 +106,7 @@ const Header = ({ showSidebar, setIsMenu, isConsole }) => {
});

return () => observer.disconnect();
}, [applogo]);
}, []);

return (
<div>
Expand All @@ -129,9 +123,11 @@ const Header = ({ showSidebar, setIsMenu, isConsole }) => {
<div className="h-[25px] md:h-[40px] w-auto overflow-hidden">
{applogo && (
<img
className="object-contain h-full w-auto"
src={applogo}
alt="logo"
src={
isDarkTheme
? "/static/js/assets/images/logo-dark.png"
: applogo
}
Copy link

Copilot AI Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an alt attribute to the <img> tag for accessibility, for example alt="App logo".

Suggested change
}
}
alt="App logo"

Copilot uses AI. Check for mistakes.
/>
)}
</div>
Expand Down
5 changes: 4 additions & 1 deletion apps/OpenSign/src/constant/Utils.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2414,7 +2414,10 @@ export const getAppLogo = async () => {
});
if (tenant) {
localStorage.setItem("appname", "OpenSign™");
return { logo: tenant?.logo, user: tenant?.user };
return {
logo: tenant?.logo,
user: tenant?.user
};
}
} catch (err) {
console.log("err in getlogo ", err);
Expand Down