Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
prafull-opensignlabs
changed the title
prafull-opensignlabs
approved these changes
Jun 19, 2025
There was a problem hiding this comment.
Pull Request Overview
A series of fixes to placeholder rendering, cell widgets, and modal validation in the OpenSign app.
- Simplify and correct validation logic (including SSN support) in widget modals.
- Introduce an
isEnabledprop for cell-based widgets and adjust related styling. - Refactor placeholder selection outline to a border overlay and update cursor behavior.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/OpenSign/src/pages/PlaceHolderSign.jsx | Removed conditional validation object and added text-base-content style class. |
| apps/OpenSign/src/components/pdf/WidgetsValueModal.jsx | Enabled CellsWidget by default, added SSN regex validation, and changed modal close handler. |
| apps/OpenSign/src/components/pdf/WidgetNameModal.jsx | Introduced handleChangeValidateInput for SSN type and updated default validation regex. |
| apps/OpenSign/src/components/pdf/PlaceholderType.jsx | Passed isEnabled prop to CellsWidget. |
| apps/OpenSign/src/components/pdf/Placeholder.jsx | Updated cursor style to move and replaced selection outline with a border overlay. |
| apps/OpenSign/src/components/pdf/CellsWidget.jsx | Added isEnabled prop to Cell and CellsWidget components. |
| apps/OpenSign/src/components/pdf/BorderResize.jsx | Consolidated multi-line style object into a single-line inline style. |
Comments suppressed due to low confidence (3)
apps/OpenSign/src/components/pdf/WidgetsValueModal.jsx:1879
- [nitpick] Function name
handleclosedoes not follow camelCase conventions; consider renaming it tohandleClosefor consistency.
const handleclose = () => {
apps/OpenSign/src/pages/PlaceHolderSign.jsx:1611
- The validation object is now always empty, disabling conditional validation. Restore the previous logic that set
validationbased onisSubscribeandinputype.
{},
apps/OpenSign/src/components/pdf/WidgetsValueModal.jsx:1949
- Removing the conditional guard allows the modal to close even when validation errors are shown. Consider preserving the
!isShowValidationcheck to prevent premature closing.
handleClose={() => handleclose()}
| import { useState, useEffect, useRef } from "react"; | ||
|
|
||
| const Cell = ({ | ||
| isEnabled, |
There was a problem hiding this comment.
Consider providing a default value for isEnabled (e.g., isEnabled = true) in the parameter destructuring to avoid it being undefined in callers that omit this prop.
Suggested change
| isEnabled, | |
| isEnabled = true, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.